Skip to content

chore(dapi-grpc): regenerate obj-c client for SUM/AVG doc updates#3759

Merged
QuantumExplorer merged 1 commit into
v3.1-devfrom
claude/fervent-bhabha-fccb41
May 27, 2026
Merged

chore(dapi-grpc): regenerate obj-c client for SUM/AVG doc updates#3759
QuantumExplorer merged 1 commit into
v3.1-devfrom
claude/fervent-bhabha-fccb41

Conversation

@QuantumExplorer
Copy link
Copy Markdown
Member

@QuantumExplorer QuantumExplorer commented May 27, 2026

Issue being fixed or feature implemented

The proto-level docstrings for GetDocumentsRequestV1 / Select / GetDocumentsResponseV1 were updated in #3661 when SUM/AVG executors landed, but the generated obj-c header was not regenerated alongside. This keeps the obj-c client in sync.

What was done?

Regenerated packages/dapi-grpc/clients/platform/v0/objective-c/Platform.pbobjc.h so the obj-c-side docstrings reflect that DOCUMENTS, COUNT(*), SUM(<field>), and AVG(<field>) are now wired end-to-end (drive count / sum / average dispatchers, both no-proof and proof paths) rather than scaffold-only. The MIN/MAX/COUNT(field) gating rationale (no grovedb min/max primitive; COUNT(field) needs a non-null counter walk) is also documented.

Doc-only — no wire format or symbol changes.

How Has This Been Tested?

  • git diff --stat: only docstrings in the generated header changed
  • Source proto already contains the matching text (packages/dapi-grpc/protos/platform/v0/platform.proto:1119), so this is a pure regeneration to bring the obj-c artifact back in sync

Breaking Changes

None — comment-only change to a generated header.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Documentation
    • Updated documentation to clarify which aggregate query functions are now supported end-to-end versus rejected during query processing.
    • Refreshed server capability matrix to reflect current support status for query aggregate functions.

Review Change Stack

Sync the obj-c generated header with the proto docstring updates from
the SUM/AVG executor landing in #3661 — DOCUMENTS, COUNT(*), SUM, and
AVG are now described as fully wired end-to-end instead of scaffold-only,
and the MIN/MAX/COUNT(field) gating rationale is documented.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@github-actions github-actions Bot added this to the v3.1.0 milestone May 27, 2026
@QuantumExplorer QuantumExplorer merged commit 0f6cbbb into v3.1-dev May 27, 2026
4 of 7 checks passed
@QuantumExplorer QuantumExplorer deleted the claude/fervent-bhabha-fccb41 branch May 27, 2026 20:18
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 27, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 68905f6c-a7c6-4489-b0db-36a9e05ebaf9

📥 Commits

Reviewing files that changed from the base of the PR and between 2842cbb and 4fe9e4f.

📒 Files selected for processing (1)
  • packages/dapi-grpc/clients/platform/v0/objective-c/Platform.pbobjc.h

📝 Walkthrough

Walkthrough

Protobuf-generated Objective-C header documentation is updated to clarify SUM/AVG aggregation function capabilities. Three docstring sections now reflect that SUM/AVG are evaluated end-to-end, while COUNT(field), MIN, and MAX remain rejected at routing time. Validation descriptions and server capability matrices are revised accordingly.

Changes

Query Aggregation Documentation

Layer / File(s) Summary
SUM/AVG aggregation documentation
packages/dapi-grpc/clients/platform/v0/objective-c/Platform.pbobjc.h
GetDocumentsRequestV1 selects validation, Select function "server capability today" matrix, and GetDocumentsResponseV1 docstrings are updated to reflect SUM/AVG moving from "not yet implemented" to "wired end-to-end" execution, with COUNT(field), MIN, and MAX remaining rejected. Updated routing dispatcher references for both non-proof and proof execution paths.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested reviewers

  • shumkov

Poem

🐰 When SUM and AVG finally shine,
From "not yet" to "working just fine",
The docs dance and leap,
While COUNT takes a sleep—
A rabbit-approved change, line by line! 🥕

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/fervent-bhabha-fccb41

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown
Contributor

✅ DashSDKFFI.xcframework built for this PR.

SwiftPM (host the zip at a stable URL, then use):

.binaryTarget(
  name: "DashSDKFFI",
  url: "https://your.cdn.example/DashSDKFFI.xcframework.zip",
  checksum: "1d8837780094943fc8015548060871f903492f21af21e89c0251e6b774682e6d"
)

Xcode manual integration:

  • Download 'DashSDKFFI.xcframework' artifact from the run link above.
  • Drag it into your app target (Frameworks, Libraries & Embedded Content) and set Embed & Sign.
  • If using the Swift wrapper package, point its binaryTarget to the xcframework location or add the package and place the xcframework at the expected path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant