chore(dapi-grpc): regenerate obj-c client for SUM/AVG doc updates#3759
Conversation
Sync the obj-c generated header with the proto docstring updates from the SUM/AVG executor landing in #3661 — DOCUMENTS, COUNT(*), SUM, and AVG are now described as fully wired end-to-end instead of scaffold-only, and the MIN/MAX/COUNT(field) gating rationale is documented. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughProtobuf-generated Objective-C header documentation is updated to clarify SUM/AVG aggregation function capabilities. Three docstring sections now reflect that SUM/AVG are evaluated end-to-end, while COUNT(field), MIN, and MAX remain rejected at routing time. Validation descriptions and server capability matrices are revised accordingly. ChangesQuery Aggregation Documentation
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested reviewers
Poem
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ DashSDKFFI.xcframework built for this PR.
SwiftPM (host the zip at a stable URL, then use): .binaryTarget(
name: "DashSDKFFI",
url: "https://your.cdn.example/DashSDKFFI.xcframework.zip",
checksum: "1d8837780094943fc8015548060871f903492f21af21e89c0251e6b774682e6d"
)Xcode manual integration:
|
Issue being fixed or feature implemented
The proto-level docstrings for
GetDocumentsRequestV1/Select/GetDocumentsResponseV1were updated in #3661 when SUM/AVG executors landed, but the generated obj-c header was not regenerated alongside. This keeps the obj-c client in sync.What was done?
Regenerated
packages/dapi-grpc/clients/platform/v0/objective-c/Platform.pbobjc.hso the obj-c-side docstrings reflect thatDOCUMENTS,COUNT(*),SUM(<field>), andAVG(<field>)are now wired end-to-end (drive count / sum / average dispatchers, both no-proof and proof paths) rather than scaffold-only. The MIN/MAX/COUNT(field) gating rationale (no grovedb min/max primitive; COUNT(field) needs a non-null counter walk) is also documented.Doc-only — no wire format or symbol changes.
How Has This Been Tested?
git diff --stat: only docstrings in the generated header changedpackages/dapi-grpc/protos/platform/v0/platform.proto:1119), so this is a pure regeneration to bring the obj-c artifact back in syncBreaking Changes
None — comment-only change to a generated header.
Checklist:
For repository code-owners and collaborators only
🤖 Generated with Claude Code
Summary by CodeRabbit