Skip to content

refactor(dashcore): replace Network field in Address with NetworkScope#802

Draft
ZocoLini wants to merge 1 commit into
devfrom
poc/network-refactor
Draft

refactor(dashcore): replace Network field in Address with NetworkScope#802
ZocoLini wants to merge 1 commit into
devfrom
poc/network-refactor

Conversation

@ZocoLini
Copy link
Copy Markdown
Collaborator

@ZocoLini ZocoLini commented Jun 3, 2026

No description provided.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jun 3, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 35385952-c805-4cd7-8d1d-dd6fe1ef8984

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch poc/network-refactor

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 3, 2026

Codecov Report

❌ Patch coverage is 85.00000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.65%. Comparing base (a132945) to head (1f147f0).

Files with missing lines Patch % Lines
dash/src/address.rs 86.48% 5 Missing ⚠️
key-wallet-ffi/src/transaction.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #802      +/-   ##
==========================================
- Coverage   72.67%   72.65%   -0.03%     
==========================================
  Files         322      322              
  Lines       71363    71367       +4     
==========================================
- Hits        51866    51852      -14     
- Misses      19497    19515      +18     
Flag Coverage Δ
core 76.53% <86.84%> (-0.01%) ⬇️
ffi 46.20% <0.00%> (-0.22%) ⬇️
rpc 20.00% <ø> (ø)
spv 90.33% <ø> (+0.03%) ⬆️
wallet 71.29% <100.00%> (ø)
Files with missing lines Coverage Δ
dash/src/sign_message.rs 79.85% <100.00%> (ø)
key-wallet/src/account/bls_account.rs 53.99% <100.00%> (ø)
key-wallet-ffi/src/transaction.rs 0.00% <0.00%> (ø)
dash/src/address.rs 57.45% <86.48%> (-0.13%) ⬇️

... and 19 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant