feat(store): rollback --store flag to to include block store in rollback

[lklimek]

Issue being fixed or feature implemented

This change introduces a new store flag to the rollback command, allowing users to optionally roll back the block store to match the state height after a rollback operation. This feature is required to ensure consistency between the block store and state during recovery scenarios.

What was done?

Updated the rollback command to include the store flag.
Modified the RollbackState function to conditionally roll back the block store based on the flag.
Added documentation for the store flag in the command description.

How Has This Been Tested?

1. Verified the rollback functionality with and without the store flag in a local testnet full node.
2. Ensured that the block store height matches the state height after rollback when the store flag is set.

Breaking Changes

None

Checklist:

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have added or updated relevant unit/integration/functional/e2e tests
• I have made corresponding changes to the documentation

For repository code-owners and collaborators only

• I have assigned this pull request to a milestone

Summary by CodeRabbit

• New Features

  • Added an optional flag to the rollback command, allowing users to roll back the block store along with the state.

• Bug Fixes

  • Improved error handling during block deletion when rolling back the block store.

[coderabbitai]

Walkthrough

The rollback command now includes an optional --store flag to also roll back the block store when rolling back state. The RollbackState function signature was updated to accept this flag. Additionally, a DeleteBlock method was introduced to the BlockStore type to enable atomic deletion of individual blocks.

Changes

File(s)	Change Summary
cmd/tenderdash/commands/rollback.go	Added --store flag to rollback command; updated RollbackState function to accept flag and delete blocks if set.
internal/store/store.go	Added DeleteBlock method to BlockStore for atomic deletion of a single block at a given height.
cmd/tenderdash/commands/rollback_test.go	Updated test calls to RollbackState to include the new boolean argument for rollbackStore flag.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant CLI
    participant RollbackState
    participant BlockStore

    User->>CLI: Run rollback command [--store]
    CLI->>RollbackState: Call with rollbackStore flag
    alt rollbackStore is true
        RollbackState->>BlockStore: DeleteBlock for each block above new state height
        BlockStore-->>RollbackState: Block(s) deleted
    end
    RollbackState-->>CLI: Return rolled-back height and app hash
    CLI-->>User: Output result

Loading

Poem

In the warren of code, a new flag appears,
Rolling back blocks as well as state, cheers!
With atomic precision, old blocks are swept,
By a bunny who prunes while the ledger is kept.
Hop, hop, hooray—rollback’s complete,
The store and the state now skip to one beat! 🐇✨

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (1.64.8)

Error: you are using a configuration file for golangci-lint v2 with golangci-lint v1: please use golangci-lint v2
Failed executing command with error: you are using a configuration file for golangci-lint v2 with golangci-lint v1: please use golangci-lint v2

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3619286 and ca7eecc.

📒 Files selected for processing (1)

• cmd/tenderdash/commands/rollback_test.go (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (6)

• GitHub Check: test_apps
• GitHub Check: test_abci_cli
• GitHub Check: tests (01)
• GitHub Check: e2e-test (rotate)
• GitHub Check: golangci-lint
• GitHub Check: e2e-test (dashcore)