Fix fusion calling things multiple times #1161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjetter
commented
Nov 11, 2024
dask_expr/_expr.py
Outdated
Comment on lines
3790
to
3800
| t = Task( | ||
| name, | ||
| Fused._execute_internal_graph, | ||
| # Wrap the actual subgraph as a data node such that the tasks are | ||
| # not erroneously parsed. The external task would otherwise carry | ||
| # the internal keys as dependencies which is satisfiable | ||
| DataNode(None, internal_tasks), | ||
| dependencies, | ||
| (self.exprs[0]._name, index), | ||
| ) | ||
| return t |
There was a problem hiding this comment.
I implemented this (and similar patterns) now two or three times. I believe I'll factor this out to a classmethod like Task.fuse_tasks. If we end up rewriting the low level fusion this will obviously also come in handy. For now, we can keep this logic to get out a fix quickly
hendrikmakait
approved these changes
Nov 11, 2024
There was a problem hiding this comment.
Thanks, @fjetter. This looks generally good to me, two non-blocking questions about comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes dask/dask#11507