Skip to content

Remove functionality of batching submission in client.map#8771

Closed
fjetter wants to merge 2 commits intodask:mainfrom
fjetter:remove_batching_client_map
Closed

Remove functionality of batching submission in client.map#8771
fjetter wants to merge 2 commits intodask:mainfrom
fjetter:remove_batching_client_map

Conversation

@fjetter
Copy link
Copy Markdown
Member

@fjetter fjetter commented Jul 16, 2024

With the HLG layer this batching is now actually harmful since pretty much the exact same object is resubmitted over and over again

@fjetter fjetter marked this pull request as draft July 16, 2024 12:37
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 16, 2024

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

    29 files  ± 0      29 suites  ±0   11h 58m 18s ⏱️ - 5m 55s
 4 087 tests + 3   3 971 ✅ + 9    112 💤 ±0  4 ❌  - 6 
55 286 runs  +42  52 842 ✅ +45  2 439 💤 +4  5 ❌  - 7 

For more details on these failures, see this check.

Results for commit a04a25f. ± Comparison against base commit ea46f72.

This pull request removes 1 and adds 4 tests. Note that renamed tests count towards both.
distributed.tests.test_scheduler ‑ test_deadlock_dependency_of_queued_released
distributed.tests.test_scheduler ‑ test_deadlock_dependency_of_queued_released_when_worker_removed[False]
distributed.tests.test_scheduler ‑ test_deadlock_dependency_of_queued_released_when_worker_removed[True]
distributed.tests.test_scheduler ‑ test_deadlock_dependency_of_queued_released_when_worker_replaced[False]
distributed.tests.test_scheduler ‑ test_deadlock_dependency_of_queued_released_when_worker_replaced[True]

♻️ This comment has been updated with latest results.

@fjetter fjetter closed this Jul 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant