-
Notifications
You must be signed in to change notification settings - Fork 5
✅: (based)pyright #53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
9b42f87
to
b4d9a83
Compare
Signed-off-by: nstarman <[email protected]>
af24393
to
d4078d7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for additional type checkers (pyright and basedmypy) to the CI workflow and updates type stub files to address compatibility issues. The changes enable testing with multiple type checkers to ensure broader type safety coverage.
- Adds pyright and basedmypy as new dependency groups in pyproject.toml
- Updates CI workflow to run mypy, basedmypy, and pyright on integration test files
- Refactors variable naming in type stub files to avoid conflicts and improve clarity
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
pyproject.toml | Adds new dependency groups for pyright and basedmypy type checkers |
.github/workflows/ci.yml | Refactors file collection logic and adds basedmypy and pyright steps to CI |
tests/integration/test_numpy1p0.pyi | Updates variable names to avoid conflicts (a_ns → has_ns, a_ns → _) |
tests/integration/test_numpy2p0.pyi | Renames underscore variables to numbered format and reorganizes comments |
tests/integration/test_numpy2p2.pyi | Renames underscore variable to descriptive name and adds explanatory comment |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Signed-off-by: nstarman <[email protected]>
@jorenham pyright & basedpyright now work |
No description provided.