Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(metrics): add progress metrics via collector #17359

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

flaneur2020
Copy link
Member

@flaneur2020 flaneur2020 commented Jan 23, 2025

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

this pr is a rework of #17266

instead of maintain a global metrics, this pr use prometheus's Collector to dump the metrics when /metrics is scraped.

Tests

  • No Test - add metrics

Type of change

  • Other (please describe): observability

This change is Reviewable

@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Jan 23, 2025
@flaneur2020 flaneur2020 marked this pull request as ready for review January 24, 2025 08:22
@flaneur2020 flaneur2020 requested a review from zhang2014 January 24, 2025 09:27
@flaneur2020 flaneur2020 requested a review from zhang2014 January 26, 2025 07:02
@zhang2014 zhang2014 added the ci-benchmark Benchmark: run all test label Feb 6, 2025
Copy link
Contributor

github-actions bot commented Feb 6, 2025

Docker Image for PR

  • tag: pr-17359-31edfaf-1738826681

note: this image tag is only available for internal use,
please check the internal doc for more details.

Copy link
Contributor

github-actions bot commented Feb 7, 2025

Docker Image for PR

  • tag: pr-17359-265858d-1738899269

note: this image tag is only available for internal use,
please check the internal doc for more details.

Copy link
Contributor

github-actions bot commented Feb 7, 2025

Docker Image for PR

  • tag: pr-17359-dc711ef-1738905094

note: this image tag is only available for internal use,
please check the internal doc for more details.

@flaneur2020 flaneur2020 added ci-benchmark Benchmark: run all test and removed ci-benchmark Benchmark: run all test labels Feb 14, 2025
Copy link
Contributor

Docker Image for PR

  • tag: pr-17359-6547226-1739520329

note: this image tag is only available for internal use,
please check the internal doc for more details.

Copy link
Contributor

Docker Image for PR

  • tag: pr-17359-46765f4-1739521690

note: this image tag is only available for internal use,
please check the internal doc for more details.

@flaneur2020
Copy link
Member Author

flaneur2020 commented Feb 14, 2025

upload failed: results/hits/result-hits-cloud-Large.json to s3://benchmark/clickbench/pr/17359/13324947345/result-hits-cloud-Large.json An error occurred (InternalError) when calling the PutObject operation (reached max retries: 2): We encountered an internal error. Please try again.
Completed 2.3 KiB/4.7 KiB (2.2 KiB/s) with 2 file(s) remaining
upload failed: results/hits/result-hits-cloud-Small.json to s3://benchmark/clickbench/pr/17359/13324947345/result-hits-cloud-Small.json An error occurred (InternalError) when calling the PutObject operation (reached max retries: 2): We encountered an internal error. Please try again.
Completed 2.3 KiB/4.7 KiB (2.2 KiB/s) with 1 file(s) remaining
Completed 4.7 KiB/4.7 KiB (2.1 KiB/s) with 1 file(s) remaining

it seems the benchmark task keeps fails constantly on uploading to r2, i have no idea about how to work around this...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-benchmark Benchmark: run all test pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants