You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
upload failed: results/hits/result-hits-cloud-Large.json to s3://benchmark/clickbench/pr/17359/13324947345/result-hits-cloud-Large.json An error occurred (InternalError) when calling the PutObject operation (reached max retries: 2): We encountered an internal error. Please try again.
Completed 2.3 KiB/4.7 KiB (2.2 KiB/s) with 2 file(s) remaining
upload failed: results/hits/result-hits-cloud-Small.json to s3://benchmark/clickbench/pr/17359/13324947345/result-hits-cloud-Small.json An error occurred (InternalError) when calling the PutObject operation (reached max retries: 2): We encountered an internal error. Please try again.
Completed 2.3 KiB/4.7 KiB (2.2 KiB/s) with 1 file(s) remaining
Completed 4.7 KiB/4.7 KiB (2.1 KiB/s) with 1 file(s) remaining
it seems the benchmark task keeps fails constantly on uploading to r2, i have no idea about how to work around this...
ci-benchmarkBenchmark: run all testpr-featurethis PR introduces a new feature to the codebase
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
this pr is a rework of #17266
instead of maintain a global metrics, this pr use prometheus's Collector to dump the metrics when /metrics is scraped.
Tests
Type of change
This change is![Reviewable](https://camo.githubusercontent.com/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)