change: Add on_commit on_complete to Responder trait
#1487
+407
−53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ariesdevil
reviewed
Nov 4, 2025
drmingdrmer
force-pushed
the
0017-responder-on-commit
branch
4 times, most recently
from
7601320 to
aa54527
Compare
xp-trumpet
previously approved these changes
Nov 4, 2025
There was a problem hiding this comment.
@xp-trumpet reviewed 14 of 18 files at r1, 2 of 2 files at r2, 5 of 5 files at r3, 1 of 1 files at r4, 2 of 2 files at r5, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @drmingdrmer and @schreter)
Add `ProgressResponder` and use it as default `Responder` that receives `on_commit` and `on_complete` events. - `on_commit` is called when a log entry is committed; - `on_complete` is called when the log entry is applied to state machine or an error occur. Replace OneshotResponder with ProgressResponder throughout the codebase to provide both commit and completion(apply or error) notifications by default. - Fix: databendlabs#1460 Upgrade tip: When not using application defined `Responder`, nothing todo. Otherwise, update the implementation of `Responder` by adding `on_commit` if needed, and replacing `send` with `on_complete`.
drmingdrmer
force-pushed
the
0017-responder-on-commit
branch
from
aa54527 to
dcc2c17
Compare
drmingdrmer
commented
Nov 4, 2025
There was a problem hiding this comment.
Reviewable status: 13 of 18 files reviewed, 1 unresolved discussion (waiting on @ariesdevil, @schreter, and @xp-trumpet)
xp-trumpet
approved these changes
Nov 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
change: Add
on_commiton_completetoRespondertraitAdd
ProgressResponderand use it as defaultResponderthat receiveson_commitandon_completeevents.on_commitis called when a log entry is committed;on_completeis called when the log entry is applied to state machineor an error occur.
Replace OneshotResponder with ProgressResponder throughout the codebase to
provide both commit and completion(apply or error) notifications by default.
Upgrade tip:
When not using application defined
Responder, nothing todo.Otherwise, update the implementation of
Responderby addingon_commitif needed, and replacingsendwithon_complete.This change is