Skip to content

[coverage] Conformance findings: PARAMQUERY-022,PARAMQUERY-023 #1802

Closed

Description

@peco-engineer-bot

Summary

Surfaced by the multi-language coverage fan-out while conformance-testing these SPEC-IDs against databricks/databricks-jdbc. Each finding is committed as an expected-failure (xfail) test in the coverage PR — the test asserts the CORRECT (post-fix) behavior and stays red until THIS driver (databricks/databricks-jdbc) is fixed, then flips green as a tripwire.

Findings

  • PARAMQUERY-022 [thrift, sea]: A bound DECIMAL parameter's value is sent as BigDecimal#toString, so a small-magnitude decimal goes on the wire in exponent notation ("1E-7") instead of the equivalent plain numeral ("0.0000001")
    • failing test: testExponentNotationDecimalParameterBindsAsPlainNumeral (see the coverage PR diff under tests/)
  • PARAMQUERY-023 [thrift, sea]: A bound DECIMAL parameter beyond the 38-digit maximum is not validated client-side: DECIMAL(39,0) is sent and the caller gets the server's opaque INVALID_PARAMETER_MARKER_VALUE.INVALID_DATA_TYPE / SQLSTATE 22023 error instead of a bind-time parameter error
    • failing test: testDecimalParameterBeyondMaximumPrecisionRejectedBeforeExecution (see the coverage PR diff under tests/)
  • PARAMQUERY-022: A bound DECIMAL parameter's value is sent as BigDecimal#toString, so a small-magnitude decimal goes on the wire in exponent notation ("1E-7", "-1.5E-7") instead of the equivalent plain numeral ("0.0000001", "-0.00000015") — on both the Thrift (TSparkParameter) and SEA (statement parameters) paths
  • PARAMQUERY-023: A bound DECIMAL parameter needing more than Databricks' maximum 38 digits of precision is not validated client-side: DatabricksTypeUtil.getDecimalTypeString emits DECIMAL(39,0) and the driver sends the ExecuteStatement, so the caller gets the server's opaque INVALID_PARAMETER_MARKER_VALUE.INVALID_DATA_TYPE / SQLSTATE 22023 error that never names the precision limit, instead of a parameter error raised at bind time

Context

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions