-
Notifications
You must be signed in to change notification settings - Fork 27
[ES-1614176] Fix: Databricks OSS JDBC Driver Fails to Authenticate After Token Update #1043
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jayantsing-db
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
u2m not working seems like a major bug. what versions we have u2m not working? curious how did this slip past testing?
src/main/java/com/databricks/jdbc/common/util/DatabricksAuthUtil.java
Outdated
Show resolved
Hide resolved
looks like a specific CUJ in U2M doesn't work and typical U2M works? |
nikhilsuri-db
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Can we write end to end test to verify this fix?
src/main/java/com/databricks/jdbc/dbclient/impl/thrift/DatabricksHttpTTransport.java
Show resolved
Hide resolved
|
@nikhilsuri-db - that is not possible at the moment. @jayantsing-db |
Description
Problem: When using con.setClientInfo("Auth_AccessToken", <new_token>) to update the access token, subsequent queries continued using the old token instead of the new one. This caused authentication failures when the new token was invalid or when the old token expired.
fix: Made databricksConfig mutable in DatabricksThriftAccessor and update it with new config (token) on con.setClientInfo("Auth_AccessToken", <new_token>) calls.
Testing
Unit tests
Additional Notes to the Reviewer