Correctly expose all Databricks error detail types in DatabricksError.
#500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renaudhartert-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
renaudhartert-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
renaudhartert-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
renaudhartert-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
renaudhartert-db
changed the title
DatabricksError.
renaudhartert-db
changed the title
DatabricksError.DatabricksError.
renaudhartert-db
changed the title
DatabricksError.DatabricksError.
renaudhartert-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
renaudhartert-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
renaudhartert-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
parthban-db
reviewed
Aug 14, 2025
...bricks-sdk-java/src/main/java/com/databricks/sdk/core/error/details/PreconditionFailure.java
Show resolved
Hide resolved
| JsonNode node = mapper.valueToTree(obj); | ||
|
|
||
| // Add the @type field. | ||
| if (node instanceof ObjectNode) { |
Contributor
There was a problem hiding this comment.
It should fail otherwise, right?
Contributor
Author
There was a problem hiding this comment.
That's right, updated.
| @@ -0,0 +1,123 @@ | |||
| package com.databricks.sdk.core.error.details; | |||
Contributor
There was a problem hiding this comment.
Do we have tests for this file?
Contributor
Author
There was a problem hiding this comment.
This is tested indirectly by the ApiClienTest logic. That being said, I would have preferred to not implement this serialization at all. The reason this is needed is because ApiClientTest are designed in a way that forces the error to be serialized.
renaudhartert-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
renaudhartert-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
parthban-db
approved these changes
Aug 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
This PR makes
ErrorDetailsaccessible inDatabricksError. This is done by replacing the list ofErrorDetailwithErrorDetails. The changes introduced in this PR are breaking for users who depended on the list ofErrorDetail.How is this tested?
Unit and integration tests.