Repository navigation
Complete native Volume transfers for ExecContext #560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
de2cd22
82ca1e1
277929b
d90432b
a87a356
d445d87
84ed9ee
23a569f
9c710a8
ae67199
85738b8
32b0a16
8d0c2c3
4c5cc0d
e37844b
aec3416
b93dacd
c1afd7c
a2b3600
cfae119
71e111f
f54641f
9c48227
c7553ab
5b61b68
6766d95
233f91a
6cdd531
caf4afc
e3930d5
72e9816
deed114
1706da4
af3a000
b296100
82bf2e4
c0c9301
ef61222
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| 0b5d0edfed32c0745d5abc2468fc3070e2eb2a17 | ||
| 23e45bafa9b0d1688fbffa5ecc975e1d91f40f01 |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -38,7 +38,9 @@ import "C" | |
| import ( | ||
| "context" | ||
| "fmt" | ||
| "os" | ||
| "runtime" | ||
| "syscall" | ||
| "unsafe" | ||
|
|
||
| "github.com/databricks/databricks-sql-go/driverctx" | ||
|
|
@@ -178,6 +180,11 @@ func lastError(code C.KernelStatusCode) *KernelError { | |
| if e.query_id != nil { | ||
| ke.QueryID = C.GoString(e.query_id) | ||
| } | ||
| ke.ErrorCode = C.GoString(C.kernel_get_last_error_code()) | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🟠 High — The PR adds cgo calls to new kernel symbols (e.g. kernel_result_stream_complete_volume_operation, kernel_get_last_error_code), but go.mod/go.sum still pin the v1.4.0 per-platform binding archives. Only KERNEL_REV and the Makefile source-build path get the new kernel, so a consumer's databricks_kernel build can fail to link. Bump the bindings pins and sums to a release that exports these symbols, and check a clean install. 🔀 Found by both reviewers · confirmed by the judge |
||
| if code := C.kernel_get_last_error_local_os_error(); code != 0 { | ||
| // The C ABI reports a path and errno without a syscall name. | ||
| ke.cause = &os.PathError{Op: "file", Path: C.GoString(C.kernel_get_last_error_local_path()), Err: syscall.Errno(code)} | ||
| } | ||
| klog("kernel error: code=%d sqlstate=%q vendor=%d http=%d retryable=%v msg=%q", | ||
| ke.Code, ke.SQLState, ke.VendorCode, ke.HTTPStatus, ke.Retryable, ke.Message) | ||
| // Also emit through the driver's logger — no SQL text or PII, just the | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.