Repository navigation
feat(kernel): honor WithPort on the kernel backend #581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cathleeny
wants to merge
10
commits into
main
Choose a base branch
from
cathleeny/feat/kernel-honor-custom-port
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
d5a6fdf
feat(kernel): honor WithPort on the kernel backend
cathleeny ba84162
fix(kernel): proxy lookup uses the kernel host authority
cathleeny 263c741
test(kernel): cover custom port on Reyden recovery; clarify port range
cathleeny 7bc6a2a
kernel: normalise trailing slash and embedded-port precedence for Wit…
cathleeny 5615750
kernel: reject paths before the embedded-port parse; no warning for e…
cathleeny 52bd5ac
kernel: keep path hosts unchanged on the default port; drop PortExplicit
cathleeny cb7a05d
Merge main into feat/kernel-honor-custom-port
cathleeny c2bcd48
kernel: parse the kernel host with net/url
cathleeny 79f43a0
fix(kernel): bracket bare IPv6 hosts and redact host credentials in e…
cathleeny b34b6fa
Merge main into feat/kernel-honor-custom-port
cathleeny File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| package config | ||
|
|
||
| import "testing" | ||
|
|
||
| // TestThriftEndpointUnchanged pins the Thrift endpoint for the port inputs the kernel custom-port | ||
| // change decides on. Thrift is not changed by that work, so these strings are what it builds today. | ||
| // An embedded host port plus the default 443 yields an unparseable URL on Thrift; that is the baseline. | ||
| func TestThriftEndpointUnchanged(t *testing.T) { | ||
| cases := []struct { | ||
| name string | ||
| host string | ||
| port int | ||
| want string | ||
| }{ | ||
| {"bare host, default port", "h.io", 443, "https://h.io:443/sql/1.0/warehouses/x"}, | ||
| {"bare host, WithPort", "h.io", 8443, "https://h.io:8443/sql/1.0/warehouses/x"}, | ||
| {"embedded port, default port", "h.io:8443", 443, "https://h.io:8443:443/sql/1.0/warehouses/x"}, | ||
| {"embedded port, WithPort", "h.io:8443", 8443, "https://h.io:8443:8443/sql/1.0/warehouses/x"}, | ||
| } | ||
| for _, tc := range cases { | ||
| t.Run(tc.name, func(t *testing.T) { | ||
| c := &Config{Protocol: "https", Host: tc.host, Port: tc.port, HTTPPath: "/sql/1.0/warehouses/x"} | ||
| got, err := c.ToEndpointURL() | ||
| if err != nil { | ||
| t.Fatalf("unexpected err %v", err) | ||
| } | ||
| if got != tc.want { | ||
| t.Errorf("ToEndpointURL() = %q, want %q", got, tc.want) | ||
| } | ||
| }) | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.