Repository navigation
learn: retrospective learnings - #589
peco-engineer-bot[bot] wants to merge 1 commit into
Conversation
Signed-off-by: peco-engineer-bot[bot] <peco-engineer-bot[bot]@users.noreply.github.com>
f0e8bf8 to
bcc24c8
Compare
There was a problem hiding this comment.
🔀 Cross-reviewed: two independent reviews (Claude Opus 5.5 · GPT-6.1 Sol), checked by a judge model (Claude Sonnet 5.5).
Verdict: 1 Medium
Docs-only learning update with 1 medium provenance concern. It looks like the branch rebuild dropped the 2026-11-20 journal file but kept the lessons distilled from it.
| - L-0020 (1×, #556): Check integer duration values against MinInt64/unit and MaxInt64/unit before multiplication; report overflow with the parameter name. | ||
| - L-0060 [phase=review] (1×, #566): Kernel applies case variants of client-only session-conf keys in sorted byte order, so the canonical lowercase key wins; check pinned session.rs before flagging map-order nondeterminism. | ||
| - L-0061 (1×, #566): Forwarding a formerly inert option to a backend is a behavior change: label it so in CHANGELOG, explain the effect of existing tuned values, and test set values, not only unset. | ||
| - L-0067 (1×, #557): Bound x/oauth2 token fetches with a copied *http.Client with capped Timeout in the context under oauth2.HTTPClient, passing that context to TokenSource; never mutate DefaultClient or the caller's client. AuthStyle auto-detect may double first-fetch time. |
There was a problem hiding this comment.
🟡 Medium — L-0066, L-0067 and L-0070, plus the L-0041 (#577) and L-0050 (#574) updates, are distilled from a 2026-11-20 journal that isn't in the checkout, so they have no source entry and the journal is no longer the record they were built from. Restore .claude/knowledge/journal/2026-11-20.md in this PR, or drop those lessons and updates until it lands.
🔀 Found by Claude Opus 5.5 · the judge couldn't confirm it
Daily learning update (distill)
The journal is one new file per run and is never edited. The lessons file is the distilled state, ordered by ID. The only paths this PR changes are one new journal file and the lessons file.
Latest update 2026-11-21. Branch: rebuilt from the default branch after a lessons.md conflict; the PR's new journal files carried over (1).
Removed lessons (review each reason)
Journal entries dropped by the per-file cap