Skip to content

test: harden Arrow precision parity for nested and dictionary values - #637

Merged
vuanhphung merged 1 commit into
mainfrom
test/arrow-nested-numeric-parity
Nov 19, 2026
Merged

vuanhphung merged 1 commit into
mainfrom
test/arrow-nested-numeric-parity

Conversation

@vuanhphung

Copy link
Copy Markdown
Collaborator

Follow up on the review suggestion in #628 with eight parity cases for nested and dictionary-encoded BIGINT/DECIMAL values under preserveBigNumericPrecision: true. Cover structs, lists, maps and both row modes with nulls, repeated values and values beyond JavaScript's safe integer range. Check explicit expected values and equality with the legacy conversion path.

Validation: all 37 Arrow materialization tests, TypeScript and Prettier pass. The new cases reject precision-loss and skipped-dictionary-conversion mutations. Full unit suite: 1,838 pass; one existing CommonJS compatibility failure comes from installed thrift@0.23.0, older than the declared ^0.25.0.

Signed-off-by: Vu Anh Phung <vu.phung@databricks.com>

@peco-review-bot peco-review-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔀 Cross-reviewed: two independent reviews (Claude Opus 5.5 · GPT-6.1 Sol), checked by a judge model (Claude Sonnet 5.5).

✅ No issues identified.

@vuanhphung
vuanhphung added this pull request to the merge queue Nov 19, 2026
Merged via the queue into main with commit 1c499e2 Nov 19, 2026
22 checks passed
@vuanhphung
vuanhphung deleted the test/arrow-nested-numeric-parity branch November 19, 2026 21:00

This branch was previously deployed

1 inactive deployment
azure-prod — 9d201e42 Deployed Nov 19, 2026 by vuanhphung via e2e-test (26.12.1, 26_12_1) #2163
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant