-
Notifications
You must be signed in to change notification settings - Fork 586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify each argument in each line, two lines limit and add invocation style guide #64
Conversation
Hi @rxin and @jkbradley. I intendedly didn't add examples when it fits in two lines, for example:
because I actually see many variants, for example:
within Spark and started to worry if we should force it. Please let me know if we should add this too, or if I missed the intention in #58. |
Not sure. I was taught this by @mengxr and have tried to enforce it in MLlib. Maybe other parts of Spark differ. |
@rxin, WDYT about this? |
Thanks - merging. You don't know Chinese, do you ? :p |
cc @Hawstein do you have time to submit a patch to reflect this update? |
@rxin Of course, will do it today when I have time. |
This PR clarifies each argument in each line, two lines limit and adds invocation style guide in "Spacing and Indentation".