Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify each argument in each line, two lines limit and add invocation style guide #64

Merged
merged 2 commits into from
Jun 4, 2018

Conversation

HyukjinKwon
Copy link
Member

This PR clarifies each argument in each line, two lines limit and adds invocation style guide in "Spacing and Indentation".

@HyukjinKwon
Copy link
Member Author

Hi @rxin and @jkbradley. I intendedly didn't add examples when it fits in two lines, for example:

foo(
  someVeryLongFieldName, andAnotherVeryLongFieldName, "this is a string", 3.1415)

because I actually see many variants, for example:

foo(someVeryLongFieldName, andAnotherVeryLongFieldName,
  "this is a string", 3.1415)

within Spark and started to worry if we should force it. Please let me know if we should add this too, or if I missed the intention in #58.

@jkbradley
Copy link

Not sure. I was taught this by @mengxr and have tried to enforce it in MLlib. Maybe other parts of Spark differ.

@HyukjinKwon
Copy link
Member Author

@rxin, WDYT about this?

@rxin
Copy link
Contributor

rxin commented Jun 4, 2018

Thanks - merging.

You don't know Chinese, do you ? :p

@rxin rxin merged commit dfbfa5f into databricks:master Jun 4, 2018
@rxin
Copy link
Contributor

rxin commented Jun 4, 2018

cc @Hawstein do you have time to submit a patch to reflect this update?

@Hawstein
Copy link
Contributor

Hawstein commented Jun 5, 2018

@rxin Of course, will do it today when I have time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants