[Feature] added databricks_app resource
#4099
Conversation
nkvuong
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
nkvuong
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
nkvuong
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
nkvuong
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
nkvuong
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
apps/resource_app.go
Outdated
| return err | ||
| } | ||
| if d.HasChanges("source_code_path", "mode") { | ||
| _, err = w.Apps.Deploy(ctx, apps.CreateAppDeploymentRequest{ |
There was a problem hiding this comment.
Should we wait here as well?
docs/resources/app.md
Outdated
| resource "databricks_app" "this" { | ||
| name = "my-custom-app" | ||
| description = "My app" | ||
| source_code_path = "/Workspace/[email protected]/my_custom_app" |
There was a problem hiding this comment.
should be /Workspace/Users/[email protected]/... ?
docs/resources/app.md
Outdated
| One or more `resource` block with the following arguments: | ||
|
|
||
| * `name` - Name of the App Resource. | ||
| * `description` - Description of the App Resource. |
There was a problem hiding this comment.
I think that it should be removed
apps/resource_app.go
Outdated
| return err | ||
| } | ||
| // now deploy the app, using the source code path | ||
| createAppDeployment.AppName = app.Name |
There was a problem hiding this comment.
I think we discussed it offline and agreed that the deployment won't be part of TF configuration. Instead, if an users want to deploy, they use CLI to do that. Otherwise it's confusing because we do the deployments only when source_code_path changed but we need to do deployments when source code is changed.
@pietern wdyt?
apps/resource_app.go
Outdated
| if err != nil { | ||
| return err | ||
| } | ||
| if d.HasChanges("source_code_path", "mode") { |
There was a problem hiding this comment.
See my comment above, I think we should remove app deployment altogether for now
nkvuong
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
nkvuong
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
nkvuong
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
nkvuong
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
|
Test Details: go/deco-tests/11836414954 |
nkvuong
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
nkvuong
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Changes
databricks_appresourceResolves #4084
Tests
make testrun locallydocs/folderinternal/acceptance