Skip to content

Conversation

@sundarshankar89
Copy link
Collaborator

Changes

What does this PR do?

Profiler Test Connection

Relevant implementation details

Caveats/things to watch out for when reviewing:

Linked issues

Resolves #..

Functionality

  • added relevant user documentation
  • added new CLI command
  • modified existing command: databricks labs lakebridge ...
  • ... +add your own

Tests

  • manually tested
  • added unit tests
  • added integration tests

@sundarshankar89 sundarshankar89 self-assigned this Dec 11, 2025
@sundarshankar89 sundarshankar89 added feat/profiler Issues related to profilers feat/cli actions that are visible to the user labels Dec 11, 2025
@codecov
Copy link

codecov bot commented Dec 11, 2025

Codecov Report

❌ Patch coverage is 15.05376% with 79 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.59%. Comparing base (b6a901f) to head (94f048e).

Files with missing lines Patch % Lines
src/databricks/labs/lakebridge/cli.py 14.58% 41 Missing ⚠️
...cks/labs/lakebridge/connections/synapse_helpers.py 12.82% 34 Missing ⚠️
...ks/labs/lakebridge/connections/database_manager.py 40.00% 3 Missing ⚠️
.../resources/assessments/synapse/common/connector.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2186      +/-   ##
==========================================
- Coverage   64.11%   63.59%   -0.52%     
==========================================
  Files         101      102       +1     
  Lines        8675     8766      +91     
  Branches      902      913      +11     
==========================================
+ Hits         5562     5575      +13     
- Misses       2941     3019      +78     
  Partials      172      172              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link

github-actions bot commented Dec 11, 2025

✅ 56/56 passed, 5 flaky, 4m12s total

Flaky tests:

  • 🤪 test_transpiles_informatica_to_sparksql_non_interactive[True] (20.696s)
  • 🤪 test_transpiles_informatica_to_sparksql (22.538s)
  • 🤪 test_transpile_teradata_sql (23.733s)
  • 🤪 test_transpiles_informatica_to_sparksql_non_interactive[False] (4.197s)
  • 🤪 test_transpile_teradata_sql_non_interactive[True] (5.913s)

Running from acceptance #3286

@sundarshankar89 sundarshankar89 marked this pull request as ready for review December 30, 2025 10:03
@sundarshankar89 sundarshankar89 requested a review from a team as a code owner December 30, 2025 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feat/cli actions that are visible to the user feat/profiler Issues related to profilers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants