Skip to content

Conversation

@asnare
Copy link
Contributor

@asnare asnare commented Dec 22, 2025

Changes

This code used to process stderr from the LSP server has been extracted out to blueprint: this PR updates the project to use the code from blueprint.

Linked Issues

Functionality

  • modified existing command: databricks labs lakebridge transpile

Tests

  • manually tested
  • existing unit tests
  • existing integration tests

@asnare asnare self-assigned this Dec 22, 2025
@asnare asnare added do-not-merge tech debt design flaws and other cascading effects internal technical pr's not end user facing labels Dec 22, 2025
@github-actions
Copy link

github-actions bot commented Dec 22, 2025

✅ 51/51 passed, 5 flaky, 4m19s total

Flaky tests:

  • 🤪 test_transpiles_informatica_to_sparksql_non_interactive[True] (21.312s)
  • 🤪 test_transpiles_informatica_to_sparksql (24.8s)
  • 🤪 test_transpile_teradata_sql_non_interactive[False] (23.112s)
  • 🤪 test_transpile_teradata_sql (25.067s)
  • 🤪 test_transpile_teradata_sql_non_interactive[True] (8.788s)

Running from acceptance #3294

@codecov
Copy link

codecov bot commented Dec 22, 2025

Codecov Report

❌ Patch coverage is 35.71429% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.96%. Comparing base (b6a901f) to head (5d54fa8).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ricks/labs/lakebridge/transpiler/lsp/lsp_engine.py 35.71% 8 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2204      +/-   ##
==========================================
- Coverage   64.11%   63.96%   -0.15%     
==========================================
  Files         101      101              
  Lines        8675     8651      -24     
  Branches      902      894       -8     
==========================================
- Hits         5562     5534      -28     
- Misses       2941     2947       +6     
+ Partials      172      170       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@asnare asnare marked this pull request as ready for review December 22, 2025 12:37
@asnare asnare requested a review from a team as a code owner December 22, 2025 12:37
@asnare asnare changed the title Live log refactor Update LSP server logging to use blueprint Dec 22, 2025
Copy link
Contributor

@m-abulazm m-abulazm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and needs blueprint release

@asnare asnare added dependencies Pull requests that update a dependency file and removed do-not-merge labels Dec 30, 2025
@asnare asnare requested a review from gueniai December 30, 2025 19:08
Copy link
Collaborator

@gueniai gueniai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gueniai gueniai merged commit b26e72f into main Dec 30, 2025
5 of 6 checks passed
@gueniai gueniai deleted the live-log-refactor branch December 30, 2025 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file internal technical pr's not end user facing tech debt design flaws and other cascading effects

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants