-
Notifications
You must be signed in to change notification settings - Fork 133
feat: implement feature flag folders for organization #280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@bimakw is attempting to deploy a commit to the Databuddy OSS Team on Vercel. A member of the Team first needs to authorize it. |
Greptile SummaryThis PR implements a folder organization system for feature flags. Flags can now be grouped into folders using a simple string path format (e.g.,
The implementation is clean and follows existing patterns. Folder paths are stored as strings with Issues found:
Confidence Score: 4/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant FlagSheet
participant FolderSelector
participant FlagsList
participant API
participant DB
User->>FlagSheet: Create/Edit Flag
FlagSheet->>API: Fetch existing flags
API->>DB: Query flags.list()
DB-->>API: Return flags with folders
API-->>FlagSheet: flags data
FlagSheet->>FolderSelector: Render with existingFolders
FolderSelector->>FolderSelector: buildFolderTree()
User->>FolderSelector: Select folder or create new
FolderSelector-->>FlagSheet: onChange(folderPath)
User->>FlagSheet: Submit form
FlagSheet->>API: flags.create/update({ folder })
API->>DB: Insert/Update with folder field
DB-->>API: Success
API-->>FlagSheet: Flag saved
FlagSheet->>FlagsList: Refresh list
FlagsList->>FlagsList: Group flags by folder
FlagsList->>FlagsList: Render FolderSections
FlagsList-->>User: Display organized flags
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
7 files reviewed, 1 comment
| FolderIcon, | ||
| FolderOpenIcon, | ||
| FolderPlusIcon, | ||
| PlusIcon, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
syntax: PlusIcon import is unused
| PlusIcon, | |
| FolderPlusIcon, |
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/dashboard/app/(main)/websites/[id]/flags/_components/folder-selector.tsx
Line: 8:8
Comment:
**syntax:** `PlusIcon` import is unused
```suggestion
FolderPlusIcon,
```
How can I resolve this? If you propose a fix, please make it concise.|
Hi, please update the branch and attach videos / screenshots of the UI changes |
|
Demo Video What the demo shows:
Test Results:
|
|
This does not at all show the folders being used, the UI, it succeeding, and anything else interactive about them.. |
Add folder system to organize feature flags in the dashboard: - Add optional `folder` text field to flags table schema - Add indexes for (websiteId, folder) and (organizationId, folder) - Update flags.list, flags.create, flags.update API endpoints - Create FolderSelector component with tree view and inline create - Update FlagsList to group flags by folders with collapsible sections - Add folder selector to FlagSheet create/edit form Closes databuddy-analytics#271
Address review comment from Greptile bot
04d0a12 to
12287bb
Compare
Summary
foldertext field to flags table (stores paths like "auth/login")Changes
folderfield to flags schema with indexes for websiteId/organizationIdflags.list,flags.create,flags.updateendpoints to support folder filteringFolderSelectorcomponent, updatedFlagsListwith folder grouping, integrated intoFlagSheetTest Plan
Screenshots
Will add screenshots after testing locally
Closes #271
/claim #271
🤖 Generated with Claude Code