Skip to content

Disable implicit builder publishing - #3

Merged
wisdomqin merged 1 commit into
mainfrom
agent/fix-release-publishing
Aug 13, 2026
Merged

wisdomqin merged 1 commit into
mainfrom
agent/fix-release-publishing

Conversation

@wisdomqin

Copy link
Copy Markdown
Contributor

What changed

  • adds --publish never to all electron-builder packaging scripts
  • keeps tag builds focused on producing artifacts
  • leaves GitHub Release creation to the dedicated publish job after all three platforms succeed
  • adds a regression test for the no-implicit-publish contract

Root cause

electron-builder detected the v0.1.0 tag and attempted implicit publishing from each platform build. Those jobs intentionally do not receive a GitHub token, so they failed after successfully producing installers.

Validation

  • npm test (23 tests)
  • npm run typecheck
  • npm run package:mac:arm64
  • git diff --check

@wisdomqin
wisdomqin merged commit cd62ef1 into main Aug 13, 2026
4 checks passed
@wisdomqin
wisdomqin deleted the agent/fix-release-publishing branch August 13, 2026 15:16
sendlan pushed a commit to sendlan/dsh-desktop that referenced this pull request Aug 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant