refactor: Move DistributedPlanError to error folder
#149
Conversation
gabotechs
deleted the branch
datafusion-contrib:gabrielmusat/execution-experiment
|
🤔 I think as soon as #145 was merged and the branch was deleted this PR got automatically closed... but I did not do it intentionally |
|
No worries, did it seems like a valid change? Should I make another pr? |
|
Let me take a look at this one now |
|
|
||
| mod arrow_error; | ||
| mod datafusion_error; | ||
| pub mod distributed_plan_error; |
There was a problem hiding this comment.
Sorry if this looked confusing, the errors module here is not really a collection of errors used along the project (as it usually happens in Rust projects). These are meant to be just Protobuf variants for upstream's DataFusionError struct rather than actual errors that can be thrown, so that means probably DistributedPlanError should not belong here.
That being said, we probably should move this errors folder inside of the protobuf now that we have one, that would scope things better and avoid confusion.
About whether having an errors module with an actual collection of errors (with just the DistributedPlanError for now), or just leaving the DistributedPlanError where it is, no strong opinion.
For @gabotechs 's #145 branch