set msrv via Cargo.toml, use 2024 edition #152
Conversation
Cargo.toml
Outdated
| edition = "2021" | ||
| edition = "2024" | ||
| rust-version = "1.86.0" |
There was a problem hiding this comment.
Our intention here is rather than enforcing ourselves a rust-version in Cargo.toml, let the datafusion crate enforce it instead. Automatically, because we are depending on datafusion, it's not necessary for us to apply further restrictions on the MSRV.
What we need to do though is to make sure that developers contributing to this project use exactly DataFusion's MSRV, therefore it's important to keep the rust-toolchain.toml file that was introduced in #72.
Any chance to keep the rust-toolchain.toml while changing it to the new 1.86.0 channel?
|
|
||
| impl DistributedCodec { | ||
| pub fn new_combined_with_user(cfg: &SessionConfig) -> impl PhysicalExtensionCodec { | ||
| pub fn new_combined_with_user(cfg: &SessionConfig) -> impl PhysicalExtensionCodec + use<> { |
There was a problem hiding this comment.
👀 use<>. Is this a thing in Rust? no idea what this means
There was a problem hiding this comment.
yeah, it means that the lifetime of the returned impl doesn't depend on the &SessionConfig
rust-toolchain.toml
Outdated
| @@ -1,3 +1,3 @@ | |||
| [toolchain] | |||
| channel = "1.85.1" | |||
| channel = "1.86.0" | |||
There was a problem hiding this comment.
🤔 Now that I think about it, probably it makes sense to leave this as 1.85.1 in this PR, as this is still running on DataFusion 49, and we need to make sure that both pipelines and developers adhere to support at least 1.85.1.
|
@gabotechs can you trigger CI so we can see if everything passes? |
|
Nice, thanks @adriangb! |
2 participants
The diff is mostly running
cargo fmton 2024 edition.