feat(upgrade): add Cleanup upgrade for Helm pre-delete infrastructure teardown#16619
Open
feat(upgrade): add Cleanup upgrade for Helm pre-delete infrastructure teardown#16619
Conversation
… teardown Adds a new `Cleanup` upgrade type to the datahub-upgrade module that tears down all DataHub infrastructure resources (Elasticsearch indices, Kafka topics, SQL database) when invoked via `-u Cleanup`. This enables clean `helm uninstall` by running as a pre-delete hook, leaving no DataHub-specific state in shared infrastructure. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
Linear: PFP-2984 |
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Add DeleteElasticsearchIndicesStepTest covering ES and OpenSearch paths, safeDelete 404/non-404 handling, and failure propagation - Add CleanupUpgradeConfigTest verifying step inclusion/exclusion based on bean availability and feature flag system properties - Add GeneralUpgradeConditionTest covering all arg combinations - Fix GeneralUpgradeCondition to null-guard getNonOptionArgs() for consistency with CleanupCondition Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
🔴 Meticulous spotted visual differences in 697 of 1625 screens tested: view and approve differences detected. Meticulous evaluated ~8 hours of user flows against your PR. Last updated for commit b5d4462. This comment will update as new commits are pushed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cleanupupgrade type todatahub-upgradethat tears down all DataHub infrastructure (ES indices, Kafka topics, SQL database)-u CleanupCLI arg, with per-subsystem enable flags (CLEANUP_KAFKA_ENABLED,CLEANUP_ELASTICSEARCH_ENABLED,CLEANUP_SQL_ENABLED)Test plan
./gradlew :datahub-upgrade:compileJavapassesdatahub-upgrade -u Cleanupagainst a local docker-compose instance and verify topics, indices, and database are removed