Skip to content

fix(ui): Disable schedule by default in ingestion form#16744

Merged
chriscollins3456 merged 1 commit intomasterfrom
cc--disable-schedule-add-upvote-buttons
Mar 25, 2026
Merged

fix(ui): Disable schedule by default in ingestion form#16744
chriscollins3456 merged 1 commit intomasterfrom
cc--disable-schedule-add-upvote-buttons

Conversation

@chriscollins3456
Copy link
Collaborator

With the change to sync schedule, we want to disable schedule by default so people don't add a schedule without meaning to.

@github-actions github-actions bot added product PR or Issue related to the DataHub UI/UX smoke_test Contains changes related to smoke tests labels Mar 24, 2026
@github-actions
Copy link
Contributor

Linear: CAT-1609

@alwaysmeticulous
Copy link

alwaysmeticulous bot commented Mar 24, 2026

✅ Meticulous spotted 0 visual differences across 1526 screens tested: view results.

Meticulous evaluated ~9 hours of user flows against your PR.

Expected differences? Click here. Last updated for commit 9e2d5fe. This comment will update as new commits are pushed.

@codecov
Copy link

codecov bot commented Mar 24, 2026

Bundle Report

Changes will increase total bundle size by 24 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
datahub-react-web-esm 22.68MB 24 bytes (0.0%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: datahub-react-web-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-*.js 24 bytes 12.45MB 0.0%

Files in assets/index-*.js:

  • ./src/providers/hooks/useHasSeenEducationStep.ts → Total Size: 488 bytes

  • ./src/app/ingestV2/source/multiStepBuilder/IngestionSourceCreatePage.tsx → Total Size: 3.68kB

  • ./src/app/ingestV2/source/multiStepBuilder/steps/step2ConnectionDetails/sections/recipeSection/sections/syncScheduleSection/ScheduleSection.tsx → Total Size: 4.0kB

@codecov
Copy link

codecov bot commented Mar 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@maggiehays maggiehays added the needs-review Label for PRs that need review from a maintainer. label Mar 25, 2026
@chriscollins3456 chriscollins3456 merged commit e52d884 into master Mar 25, 2026
52 checks passed
@chriscollins3456 chriscollins3456 deleted the cc--disable-schedule-add-upvote-buttons branch March 25, 2026 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-review Label for PRs that need review from a maintainer. product PR or Issue related to the DataHub UI/UX smoke_test Contains changes related to smoke tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants