Skip to content

fix(ui): Add glossary section to policy view only modal#16745

Merged
chriscollins3456 merged 1 commit intomasterfrom
cc--fix-view-glossary-policy
Mar 25, 2026
Merged

fix(ui): Add glossary section to policy view only modal#16745
chriscollins3456 merged 1 commit intomasterfrom
cc--fix-view-glossary-policy

Conversation

@chriscollins3456
Copy link
Collaborator

This section was forgotten where you can review a policy without editing it in a "read only" state - we just need to list the selected terms and groups if the flag is enabled.

Screenshot 2026-03-05 at 5 42 54 PM

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Mar 24, 2026
@chriscollins3456 chriscollins3456 changed the title fix(ui): Add glossary section to policy view only modal (#8492) fix(ui): Add glossary section to policy view only modal Mar 24, 2026
@github-actions
Copy link
Contributor

Linear: CAT-1610

@alwaysmeticulous
Copy link

alwaysmeticulous bot commented Mar 24, 2026

✅ Meticulous spotted 0 visual differences across 1526 screens tested: view results.

Meticulous evaluated ~9 hours of user flows against your PR.

Expected differences? Click here. Last updated for commit 0f4516a. This comment will update as new commits are pushed.

@codecov
Copy link

codecov bot commented Mar 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@codecov
Copy link

codecov bot commented Mar 24, 2026

Bundle Report

Changes will increase total bundle size by 255 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
datahub-react-web-esm 22.69MB 255 bytes (0.0%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: datahub-react-web-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-*.js 255 bytes 12.45MB 0.0%

Files in assets/index-*.js:

  • ./src/app/permissions/policy/PolicyDetailsModal.tsx → Total Size: 10.88kB

@maggiehays maggiehays added the needs-review Label for PRs that need review from a maintainer. label Mar 25, 2026
@chriscollins3456 chriscollins3456 merged commit eca51ea into master Mar 25, 2026
49 of 51 checks passed
@chriscollins3456 chriscollins3456 deleted the cc--fix-view-glossary-policy branch March 25, 2026 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-review Label for PRs that need review from a maintainer. product PR or Issue related to the DataHub UI/UX

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants