fix(ingestion): Bump up pyodbc upper constraint#16746
fix(ingestion): Bump up pyodbc upper constraint#16746kyungsoo-datahub wants to merge 5 commits intomasterfrom
Conversation
|
Linear: ING-2049 |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Connector Tests ResultsAll connector tests passed for commit To skip connector tests, add the Autogenerated by the connector-tests CI pipeline. |
|
✅ Meticulous spotted 0 visual differences across 1526 screens tested: view results. Meticulous evaluated ~8 hours of user flows against your PR. Expected differences? Click here. Last updated for commit 1e338f0. This comment will update as new commits are pushed. |
Bundle ReportChanges will decrease total bundle size by 131 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: datahub-react-web-esmAssets Changed:
|
|
Your PR has been assigned to anush.kumar for review (ING-2049). |
Summary
<5.0to<6.0infabric-onelake,all, andintegration-testsextrasWhy
pyodbc 4.x has no Python 3.12 binary wheels.
Why the major version bump is safe
pyodbc 5.0 bumped the major version solely to drop Python 2. The release notes state: "The API is backwards compatible, so previous Python 3 products using pyodbc should not need any changes." No changes to
connect(),Connection,Cursor,Row, or data type handling across 5.0–5.3.Our usage (
pyodbc.connect()withattrs_before,add_output_converter,mssql+pyodbc://SQLAlchemy dialect) is all stable API. The one 5.0.0 regression (bytes inattrs_before) was fixed in 5.0.1; we pin to 5.3.0.