fix(openapi): accept requests without trailing slash on v1 relationsh…#16773
Open
rospe wants to merge 5 commits intodatahub-project:masterfrom
Open
fix(openapi): accept requests without trailing slash on v1 relationsh…#16773rospe wants to merge 5 commits intodatahub-project:masterfrom
rospe wants to merge 5 commits intodatahub-project:masterfrom
Conversation
…ips endpoint Spring Boot 3.x disabled trailing slash matching by default. The v1 RelationshipsController maps @GetMapping(value = "/") which only matches /openapi/relationships/v1/ (with trailing slash). Reverse proxies commonly strip trailing slashes, causing 404 errors when the migrate dataplatform2instance CLI command calls this endpoint. Accept both paths by mapping to {"", "/"}. Fixes: datahub-project#15538
github-actions
bot
added
devops
Contributor
|
Linear: CAT-1621 Thanks for your contribution! We have created an internal ticket to track this PR. A member of the core DataHub team will be assigned to review it within the next few business days - you will get a follow-up comment once a reviewer is assigned. |
maggiehays
added
the
needs-review
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
gabe-lyons
approved these changes
Mar 26, 2026
Author
|
Hi @gabe-lyons , there seem to be some flaky cypress tests - can you rerun or merge? I wouldn't know how they are linked to this patch. |
maggiehays
added
merge-pending-ci
Bundle ReportBundle size has no change ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ips endpoint
Spring Boot 3.x disabled trailing slash matching by default. The v1 RelationshipsController maps @GetMapping(value = "/") which only matches /openapi/relationships/v1/ (with trailing slash). Reverse proxies commonly strip trailing slashes, causing 404 errors when the migrate dataplatform2instance CLI command calls this endpoint.
Accept both paths by mapping to {"", "/"}.
Fixes: #15538