-
Notifications
You must be signed in to change notification settings - Fork 1
[sc-241566] Add ElementName column to attribute search #72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feature/sc-241416-allow-maxCount-tuning
Are you sure you want to change the base?
[sc-241566] Add ElementName column to attribute search #72
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works fine - indeed it's pretty simple... but I think we could probably:
- remove the flag (add_element_name) as unneeded complexity
- add a unit test like this (I have this locally, can commit it if you agreed)
def test_get_element_name_from_path(self):
assert get_element_name_from_path("\\osisoft-pi-serv\\Well\\Assets\\TX532|Current") == 'TX532'
assert get_element_name_from_path("\\osisoft-pi-serv\\Well\\Assets\\TX532") == 'TX532'
assert get_element_name_from_path("TX532") == 'TX532'
self.assertIsNone(get_element_name_from_path(""))
assert get_element_name_from_path("|mknnkn") == ""
assert get_element_name_from_path("\\something\\|mknnkn") == ""
…c-241566-add-elementname-column-to-attribute-search
👍 added in d516709 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks - LGTM!
…c-241566-add-elementname-column-to-attribute-search
Story details: https://app.shortcut.com/dataiku/story/241566