(finalizers): refactor #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdheipSingh
requested changes
Dec 30, 2023
controllers/druid/finalizers.go
Outdated
Comment on lines
93
to
95
| msg := fmt.Sprintf("Trigerring finalizer for CR [%s] in namespace [%s]", m.Name, m.Namespace) | ||
| // sendEvent(sdk, m, v1.EventTypeNormal, DruidFinalizer, msg) | ||
| logger.Info(msg) |
There was a problem hiding this comment.
as we our refactoring, we can convert this to an event.
AdheipSingh
approved these changes
Jan 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Code refactoring to the finalizers' logic. Added also tests.
I didn't refactor the entire code since its complicated to do all at once.
This PR has:
Key changed/added files in this PR
controllers/druid/finalizers.gocontrollers/druid/finalizers_test.gocontrollers/druid/handler.gocontrollers/druid/suite_test.go