Skip to content

Conversation

@BenjaminCharmes
Copy link
Contributor

Related to issue #1016 and another version of PR #1035

Add metadata visualisation and FileMultiSelectDropdown to all blocks

@BenjaminCharmes BenjaminCharmes changed the title [WIP] [WIP] Add Metadata and use FileMultiSelectDropdown in every blocks Nov 18, 2025
@codecov
Copy link

codecov bot commented Dec 3, 2025

Codecov Report

❌ Patch coverage is 28.57143% with 40 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.76%. Comparing base (4243930) to head (6e68f8c).

Files with missing lines Patch % Lines
pydatalab/src/pydatalab/apps/nmr/blocks.py 31.25% 22 Missing ⚠️
pydatalab/src/pydatalab/apps/xrd/blocks.py 25.00% 18 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1436      +/-   ##
==========================================
- Coverage   79.34%   78.76%   -0.59%     
==========================================
  Files          70       70              
  Lines        5099     5148      +49     
==========================================
+ Hits         4046     4055       +9     
- Misses       1053     1093      +40     
Files with missing lines Coverage Δ
pydatalab/src/pydatalab/apps/xrd/blocks.py 82.43% <25.00%> (-7.84%) ⬇️
pydatalab/src/pydatalab/apps/nmr/blocks.py 76.66% <31.25%> (-10.09%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cypress
Copy link

cypress bot commented Dec 3, 2025

datalab    Run #4271

Run Properties:  status check passed Passed #4271  •  git commit d6a85920d0 ℹ️: Merge 6e68f8ce601be1d456e46b5d6684ca3c386a187e into 42439305edbc49d0278b0d992815...
Project datalab
Branch Review bc/datablock-upgrade
Run status status check passed Passed #4271
Run duration 09m 38s
Commit git commit d6a85920d0 ℹ️: Merge 6e68f8ce601be1d456e46b5d6684ca3c386a187e into 42439305edbc49d0278b0d992815...
Committer Ben Charmes
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 456
View all changes introduced in this branch ↗︎

@BenjaminCharmes BenjaminCharmes changed the title [WIP] Add Metadata and use FileMultiSelectDropdown in every blocks Add Metadata and use FileMultiSelectDropdown in every blocks Dec 3, 2025
@BenjaminCharmes BenjaminCharmes marked this pull request as ready for review December 3, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants