Prevent double-click on modal submit button

[BenjaminCharmes]

Closes #1453

Prevents double-clicking the submit button in modals by immediately locking it before the API responds.

Changes:

• Changed submit button from type="submit" to type="button" with manual form submission
• Added submitLocked flag that locks on first click
• Use requestSubmit() with fallbacks to trigger form submission

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.46%. Comparing base (c588dcb) to head (037be16).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1455      +/-   ##
==========================================
- Coverage   79.52%   79.46%   -0.06%     
==========================================
  Files          70       70              
  Lines        5000     5055      +55     
==========================================
+ Hits         3976     4017      +41     
- Misses       1024     1038      +14     

see 2 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[cypress]

datalab    Run #4257

Run Properties:   Passed #4257  •  250e200aa1 ℹ️: Merge 037be1681f9013b82f615c422a67fe94488a900f into 936e6b7cb4eff66b3521f6196201...

Project	datalab
Branch Review	bc/double-submit
Run status	Passed #4257
Run duration	08m 35s
Commit	250e200aa1 ℹ️: Merge 037be1681f9013b82f615c422a67fe94488a900f into 936e6b7cb4eff66b3521f6196201...
Committer	Ben Charmes
View all properties for this run ↗︎

---

Test results
Failures	0
Flaky	0
Pending	0
Skipped	0
Passing	456
View all changes introduced in this branch ↗︎

[ml-evs]

Thanks for this @BenjaminCharmes!

Couple of points that we are discussing as I type:

• this approach looks good as it works for all modals, but the lockAndSubmit method needs some comments to help me understand it for the future
• also the original bug behaviour is a bit strange -- the duplicate items seem to disappear on refresh, indicating that the API requests are never actually made, so this may need to be fixed elsewhere too

[BenjaminCharmes]

Couple of points that we are discussing as I type:

• this approach looks good as it works for all modals, but the lockAndSubmit method needs some comments to help me understand it for the future

You're right, the previous approach was overkill. This event-based solution is much easier.

[BenjaminCharmes]

• also the original bug behaviour is a bit strange -- the duplicate items seem to disappear on refresh, indicating that the API requests are never actually made, so this may need to be fixed elsewhere too

Looks like both API requests succeed (when using automatic ID generation), items are just sorted differently after refresh but still exist in the database.