Allow normal click to open items in same tab from table #1468
+41
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1468 +/- ##
==========================================
- Coverage 79.46% 79.34% -0.12%
==========================================
Files 70 70
Lines 5055 5099 +44
==========================================
+ Hits 4017 4046 +29
- Misses 1038 1053 +15 🚀 New features to boost your workflow:
|
datalab
|
||||||||||||||||||||||||||||
| Project |
datalab
|
| Branch Review |
bc/datatable-click
|
| Run status |
|
| Run duration | 08m 32s |
| Commit |
|
| Committer | Ben Charmes |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
456
|
| View all changes introduced in this branch ↗︎ | |
BenjaminCharmes
force-pushed
the
bc/datatable-click
branch
14 times, most recently
from
68e8000 to
21fbbbc
Compare
Allow normal click to open items in same tab from DataTable Allow normal click to open items in same tab from DataTable Don't let cypress open new tab Don't let cypress open new tab Don't let cypress open new tab Don't let cypress open new tab Don't let cypress open new tab Don't let cypress open new tab Don't let cypress open new tab Don't let cypress open new tab Don't let cypress open new tab Don't let cypress open new tab Don't let cypress open new tab Don't let cypress open new tab Don't let cypress open new tab
ml-evs
force-pushed
the
bc/datatable-click
branch
from
21fbbbc to
a7ad41b
Compare
Member
|
Can you make the modified click open the page in a new tab in the background (i.e., don't change focus to the new tab)?That's standard for browsers. |
Contributor
Author
I removed window.focus() to use the browser's default behavior, trying to force focus on modified click didn't work anyway (at least for me on mac) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1465
Changes click behavior in DataTable for both items and collections: