Reverted JoinListStore#internalAdd to non bulk shift insertion strategy to avoid issue #464#465
Open
chrisco484 wants to merge 1 commit intodatanucleus:5.2from
Open
Reverted JoinListStore#internalAdd to non bulk shift insertion strategy to avoid issue #464#465chrisco484 wants to merge 1 commit intodatanucleus:5.2from
chrisco484 wants to merge 1 commit intodatanucleus:5.2from
Conversation
… AbstractlistStore - did not resolve issue datanucleus#464 Reverted JoinListStore#internalAdd to non bulk shift insertion strategy and the exception of issue datanucleus#464 no longer occurs.
Contributor
Author
|
Note: this change is on the 5.2 branch only. I'm not sure if Master branch exhibits the same issue with MySQL as I haven't had the time to install JDK 11 to test 6.x |
Member
|
I wont be ripping out code just because some corner case has some issue. You could provide a PR that allows a field to be marked with some metadata extension NOT to do bulk shift with that field perhaps ... that way the majority get the benefit of that code, and those who don't want it can opt out |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also: Fixed potential typo in passing shiftStmt instead of shiftBulkStmt in AbstractlistStore - did not resolve issue #464
This only reverts the bulk shift for 1-m relationships implemented via join tables as they are the only ones exhibiting the exception in MySQL.
Bulk shifts for 1-m relationships implemented by FK are still in place.