Fix bulk shift ordering to prevent duplicate key violations on MySQL#508
Open
jasper-vandemalle wants to merge 2 commits intodatanucleus:masterfrom
Open
Fix bulk shift ordering to prevent duplicate key violations on MySQL#508jasper-vandemalle wants to merge 2 commits intodatanucleus:masterfrom
jasper-vandemalle wants to merge 2 commits intodatanucleus:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #464.
When shifting list indices upward (inserting before the end of a list), MySQL processes the bulk
UPDATE ... SET idx = idx + 1in ascending primary key order. The row at the lowest index gets updated first, and its new value collides with the next row's current index.This adds
ORDER BY idx DESCto the bulk shift statement for positive shifts, so the highest-index row moves first and each update lands in a vacant slot. Negative shifts (from remove operations) already work correctly with ascending order.ORDER BYinUPDATEis a MySQL/MariaDB extension not supported by PostgreSQL, Oracle, or SQL Server, so this is gated behind a newORDER_BY_IN_UPDATE_STATEMENTadapter capability. MySQL and H2 register it; other databases keep the existing behavior.Also fixes a minor bug in the
internalShiftBulkcatch block that referencedshiftStmtinstead of the localshiftBulkStmt.Also included an additional integration test: