Skip to content

Commit

Permalink
add confirm back in
Browse files Browse the repository at this point in the history
  • Loading branch information
andreasjordan committed Oct 11, 2024
1 parent f10be51 commit 34eb672
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 13 deletions.
6 changes: 3 additions & 3 deletions tests/Get-DbaAgListener.Tests.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,11 @@ Describe "$CommandName Unit Tests" -Tag 'UnitTests' {
Describe "$commandname Integration Tests" -Tag "IntegrationTests" {
BeforeAll {
$agname = "dbatoolsci_ag_listener"
$ag = New-DbaAvailabilityGroup -Primary $script:instance3 -Name $agname -ClusterType None -FailoverMode Manual -Certificate dbatoolsci_AGCert
$ag | Add-DbaAgListener -IPAddress 127.0.20.1 -Port 14330
$ag = New-DbaAvailabilityGroup -Primary $script:instance3 -Name $agname -ClusterType None -FailoverMode Manual -Certificate dbatoolsci_AGCert -Confirm:$false
$ag | Add-DbaAgListener -IPAddress 127.0.20.1 -Port 14330 -Confirm:$false
}
AfterAll {
$null = Remove-DbaAvailabilityGroup -SqlInstance $script:instance3 -AvailabilityGroup $agname
$null = Remove-DbaAvailabilityGroup -SqlInstance $script:instance3 -AvailabilityGroup $agname -Confirm:$false
}
Context "gets ags" {
It "returns results with proper data" {
Expand Down
5 changes: 2 additions & 3 deletions tests/Get-DbaAgReplica.Tests.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,11 @@ Describe "$commandname Unit Tests" -Tag 'UnitTests' {
Describe "$commandname Integration Tests" -Tag "IntegrationTests" {
BeforeAll {
$agname = "dbatoolsci_agroup"
$ag = New-DbaAvailabilityGroup -Primary $script:instance3 -Name $agname -ClusterType None -FailoverMode Manual -Certificate dbatoolsci_AGCert
$ag = New-DbaAvailabilityGroup -Primary $script:instance3 -Name $agname -ClusterType None -FailoverMode Manual -Certificate dbatoolsci_AGCert -Confirm:$false
$replicaName = $ag.PrimaryReplica
}
AfterAll {
$null = Remove-DbaAvailabilityGroup -SqlInstance $script:instance3 -AvailabilityGroup $agname
$null = Remove-DbaAvailabilityGroup -SqlInstance $script:instance3 -AvailabilityGroup $agname -Confirm:$false
}
Context "gets ag replicas" {
It "returns results with proper data" {
Expand All @@ -30,7 +30,6 @@ Describe "$commandname Integration Tests" -Tag "IntegrationTests" {
$results.AvailabilityMode | Should -Contain 'SynchronousCommit'
}
It "returns just one result" {
$server = Connect-DbaInstance -SqlInstance $script:instance3
$results = Get-DbaAgReplica -SqlInstance $script:instance3 -Replica $replicaName -AvailabilityGroup $agname
$results.AvailabilityGroup | Should -Be $agname
$results.Role | Should -Be 'Primary'
Expand Down
4 changes: 2 additions & 2 deletions tests/New-DbaAvailabilityGroup.Tests.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -28,12 +28,12 @@ Describe "$commandname Integration Tests" -Tag "IntegrationTests" {
}
Context "adds an ag" {
It "returns an ag with a db named" {
$results = New-DbaAvailabilityGroup -Primary $script:instance3 -Name $agname -ClusterType None -FailoverMode Manual -Database $dbname -Certificate dbatoolsci_AGCert
$results = New-DbaAvailabilityGroup -Primary $script:instance3 -Name $agname -ClusterType None -FailoverMode Manual -Database $dbname -Certificate dbatoolsci_AGCert -Confirm:$false
$results.AvailabilityDatabases.Name | Should -Be $dbname
$results.AvailabilityDatabases.Count | Should -Be 1 -Because "There should be only the named database in the group"
}
It "returns an ag with no database if one was not named" {
$results = New-DbaAvailabilityGroup -Primary $script:instance3 -Name $agname -ClusterType None -FailoverMode Manual -Certificate dbatoolsci_AGCert
$results = New-DbaAvailabilityGroup -Primary $script:instance3 -Name $agname -ClusterType None -FailoverMode Manual -Certificate dbatoolsci_AGCert -Confirm:$false
$results.AvailabilityDatabases.Count | Should -Be 0 -Because "No database was named"
}
}
Expand Down
10 changes: 5 additions & 5 deletions tests/Set-DbaAgReplica.Tests.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -16,25 +16,25 @@ Describe "$CommandName Unit Tests" -Tag 'UnitTests' {
Describe "$commandname Integration Tests" -Tag "IntegrationTests" {
BeforeAll {
$agname = "dbatoolsci_arepgroup"
$ag = New-DbaAvailabilityGroup -Primary $script:instance3 -Name $agname -ClusterType None -FailoverMode Manual -Certificate dbatoolsci_AGCert
$ag = New-DbaAvailabilityGroup -Primary $script:instance3 -Name $agname -ClusterType None -FailoverMode Manual -Certificate dbatoolsci_AGCert -Confirm:$false
$replicaName = $ag.PrimaryReplica
}
AfterAll {
Remove-DbaAvailabilityGroup -SqlInstance $script:instance3 -AvailabilityGroup $agname
Remove-DbaAvailabilityGroup -SqlInstance $script:instance3 -AvailabilityGroup $agname -Confirm:$false
}
Context "sets ag properties" {
It "returns modified results" {
$results = Set-DbaAgReplica -SqlInstance $script:instance3 -AvailabilityGroup $agname -Replica $replicaName -BackupPriority 100
$results = Set-DbaAgReplica -SqlInstance $script:instance3 -AvailabilityGroup $agname -Replica $replicaName -BackupPriority 100 -Confirm:$false
$results.AvailabilityGroup | Should -Be $agname
$results.BackupPriority | Should -Be 100
}
It "returns modified results" {
$results = Set-DbaAgReplica -SqlInstance $script:instance3 -AvailabilityGroup $agname -Replica $replicaName -SeedingMode Automatic
$results = Set-DbaAgReplica -SqlInstance $script:instance3 -AvailabilityGroup $agname -Replica $replicaName -SeedingMode Automatic -Confirm:$false
$results.AvailabilityGroup | Should -Be $agname
$results.SeedingMode | Should -Be Automatic
}
It "attempts to add a ReadOnlyRoutingList" {
$null = Get-DbaAgReplica -SqlInstance $script:instance3 -AvailabilityGroup $agname | Select-Object -First 1 | Set-DbaAgReplica -ReadOnlyRoutingList nondockersql -WarningAction SilentlyContinue -WarningVariable warn
$null = Get-DbaAgReplica -SqlInstance $script:instance3 -AvailabilityGroup $agname | Select-Object -First 1 | Set-DbaAgReplica -ReadOnlyRoutingList nondockersql -WarningAction SilentlyContinue -WarningVariable warn -Confirm:$false
$warn | Should -match "does not exist. Only availability"
}
}
Expand Down

0 comments on commit 34eb672

Please sign in to comment.