Skip to content

Commit

Permalink
Merge branch 'development' of https://github.com/dataplat/dbatools in…
Browse files Browse the repository at this point in the history 
…to development
  • Loading branch information
@potatoqualitee
potatoqualitee committed Oct 16, 2024
2 parents 63c036e + f2b4279 commit 50b1d2b
Show file tree
Hide file tree
Showing 3 changed files with 33 additions and 17 deletions.
19 changes: 9 additions & 10 deletions tests/Copy-DbaEndpoint.Tests.ps1
View file
Original file line number Diff line number Diff line change
Expand Up @@ -20,22 +20,21 @@ Describe "$CommandName Unit Tests" -Tag 'UnitTests' {

Describe "$commandname Integration Tests" -Tag "IntegrationTests" {
BeforeAll {
$endpoint = Get-DbaEndpoint -SqlInstance $script:instance2 | Where-Object EndpointType -eq DatabaseMirroring
$create = $endpoint | Export-DbaScript -Passthru
$null = $endpoint | Remove-DbaEndpoint -Confirm:$false
$results = New-DbaEndpoint -SqlInstance $script:instance2 -Type DatabaseMirroring -Role Partner -Name Mirroring -Confirm:$false
Get-DbaEndpoint -SqlInstance $script:instance2 -Type DatabaseMirroring | Remove-DbaEndpoint -Confirm:$false
New-DbaEndpoint -SqlInstance $script:instance2 -Name dbatoolsci_MirroringEndpoint -Type DatabaseMirroring -Port 5022 -Owner sa
Get-DbaEndpoint -SqlInstance $script:instance3 -Type DatabaseMirroring | Remove-DbaEndpoint -Confirm:$false
}
AfterAll {
if ($create) {
$null = Get-DbaEndpoint -SqlInstance $script:instance2, $script:instance3 | Where-Object EndpointType -eq DatabaseMirroring | Remove-DbaEndpoint -Confirm:$false
Invoke-DbaQuery -SqlInstance $script:instance2 -Query "$create"
}
Get-DbaEndpoint -SqlInstance $script:instance2 -Type DatabaseMirroring | Remove-DbaEndpoint -Confirm:$false
New-DbaEndpoint -SqlInstance $script:instance2 -Name dbatoolsci_MirroringEndpoint -Type DatabaseMirroring -Port 5022 -Owner sa
Get-DbaEndpoint -SqlInstance $script:instance3 -Type DatabaseMirroring | Remove-DbaEndpoint -Confirm:$false
New-DbaEndpoint -SqlInstance $script:instance3 -Name dbatoolsci_MirroringEndpoint -Type DatabaseMirroring -Port 5023 -Owner sa
}

It "copies an endpoint" {
$results = Copy-DbaEndpoint -Source $script:instance2 -Destination $script:instance3 -Endpoint Mirroring
$results = Copy-DbaEndpoint -Source $script:instance2 -Destination $script:instance3 -Endpoint dbatoolsci_MirroringEndpoint
$results.DestinationServer | Should -Be $script:instance3
$results.Status | Should -Be 'Successful'
$results.Name | Should -Be 'Mirroring'
$results.Name | Should -Be 'dbatoolsci_MirroringEndpoint'
}
}
14 changes: 9 additions & 5 deletions tests/Set-DbaNetworkConfiguration.Tests.ps1
View file
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ Describe "$CommandName Integration Tests" -Tags "IntegrationTests" {
Context "Command works with piped input" {
$netConf = Get-DbaNetworkConfiguration -SqlInstance $script:instance2
$netConf.TcpIpProperties.KeepAlive = 60000
$results = $netConf | Set-DbaNetworkConfiguration -Confirm:$false
$results = $netConf | Set-DbaNetworkConfiguration -Confirm:$false -WarningAction SilentlyContinue

It "Should Return a Result" {
$results.ComputerName | Should -Be $netConf.ComputerName
Expand All @@ -25,14 +25,18 @@ Describe "$CommandName Integration Tests" -Tags "IntegrationTests" {
It "Should Return a Change" {
$results.Changes | Should -Match "Changed TcpIpProperties.KeepAlive to 60000"
}

$netConf = Get-DbaNetworkConfiguration -SqlInstance $script:instance2
$netConf.TcpIpProperties.KeepAlive = 30000
$null = $netConf | Set-DbaNetworkConfiguration -Confirm:$false -WarningAction SilentlyContinue
}

Context "Command works with commandline input" {
$netConf = Get-DbaNetworkConfiguration -SqlInstance $script:instance2
if ($netConf.NamedPipesEnabled) {
$results = Set-DbaNetworkConfiguration -SqlInstance $script:instance2 -DisableProtocol NamedPipes -Confirm:$false
$results = Set-DbaNetworkConfiguration -SqlInstance $script:instance2 -DisableProtocol NamedPipes -Confirm:$false -WarningAction SilentlyContinue
} else {
$results = Set-DbaNetworkConfiguration -SqlInstance $script:instance2 -EnableProtocol NamedPipes -Confirm:$false
$results = Set-DbaNetworkConfiguration -SqlInstance $script:instance2 -EnableProtocol NamedPipes -Confirm:$false -WarningAction SilentlyContinue
}

It "Should Return a Result" {
Expand All @@ -44,9 +48,9 @@ Describe "$CommandName Integration Tests" -Tags "IntegrationTests" {
}

if ($netConf.NamedPipesEnabled) {
$null = Set-DbaNetworkConfiguration -SqlInstance $script:instance2 -EnableProtocol NamedPipes -Confirm:$false
$null = Set-DbaNetworkConfiguration -SqlInstance $script:instance2 -EnableProtocol NamedPipes -Confirm:$false -WarningAction SilentlyContinue
} else {
$null = Set-DbaNetworkConfiguration -SqlInstance $script:instance2 -DisableProtocol NamedPipes -Confirm:$false
$null = Set-DbaNetworkConfiguration -SqlInstance $script:instance2 -DisableProtocol NamedPipes -Confirm:$false -WarningAction SilentlyContinue
}
}
}
17 changes: 15 additions & 2 deletions tests/Start-DbaXESession.Tests.ps1
View file
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ Describe "$CommandName Integration Tests" -Tags "IntegrationTests" {
# Drop created objects
$conn.ExecuteNonQuery("IF EXISTS(SELECT * FROM sys.server_event_sessions WHERE name = 'dbatoolsci_session_invalid') DROP EVENT SESSION [dbatoolsci_session_invalid] ON SERVER;")
$conn.ExecuteNonQuery("IF EXISTS(SELECT * FROM sys.server_event_sessions WHERE name = 'dbatoolsci_session_valid') DROP EVENT SESSION [dbatoolsci_session_valid] ON SERVER;")
Get-DbaAgentSchedule -SqlInstance $script:instance2 -Schedule "XE Session START - dbatoolsci_session_valid", "XE Session STOP - dbatoolsci_session_valid" | Remove-DbaAgentSchedule -Force -Confirm:$false
}

Context "Verifying command works" {
Expand Down Expand Up @@ -90,22 +91,34 @@ Describe "$CommandName Integration Tests" -Tags "IntegrationTests" {
It "works when -StopAt is passed" {
$StopAt = (Get-Date).AddSeconds(10)
Start-DbaXESession $server -Session $dbatoolsciValid.Name -StopAt $StopAt -WarningAction SilentlyContinue
$dbatoolsciValid.Refresh()
$dbatoolsciValid.IsRunning | Should Be $true
(Get-DbaAgentJob -SqlInstance $server -Job "XE Session STOP - dbatoolsci_session_valid").Count | Should -Be 1
$stopSchedule = Get-DbaAgentSchedule -SqlInstance $server -Schedule "XE Session STOP - dbatoolsci_session_valid"
$stopSchedule.ActiveStartTimeOfDay.ToString('hhmmss') | Should -Be $StopAt.TimeOfDay.ToString('hhmmss')
$stopSchedule.ActiveStartDate | Should -Be $StopAt.Date
Start-Sleep -Seconds 11
$dbatoolsciValid.Refresh()
$dbatoolsciValid.IsRunning | Should Be $false
# Using $script:instance2 because the SMO $server is not updated after the job is removed
(Get-DbaAgentJob -SqlInstance $script:instance2 -Job "XE Session STOP - dbatoolsci_session_valid").Count | Should -Be 0
}

It "works when -StartAt is passed" {
$null = Stop-DbaXESession -SqlInstance $server -Session $dbatoolsciValid.Name -WarningAction SilentlyContinue
$StartAt = (Get-Date).AddSeconds(10)
$session = Start-DbaXESession $server -Session $dbatoolsciValid.Name -StartAt $StartAt
$session.IsRunning | Should Be $false
$null = Start-DbaXESession $server -Session $dbatoolsciValid.Name -StartAt $StartAt
$dbatoolsciValid.Refresh()
$dbatoolsciValid.IsRunning | Should Be $false
(Get-DbaAgentJob -SqlInstance $server -Job "XE Session START - dbatoolsci_session_valid").Count | Should -Be 1
$startSchedule = Get-DbaAgentSchedule -SqlInstance $server -Schedule "XE Session START - dbatoolsci_session_valid"
$startSchedule.ActiveStartTimeOfDay.ToString('hhmmss') | Should -Be $StartAt.TimeOfDay.ToString('hhmmss')
$startSchedule.ActiveStartDate | Should -Be $StartAt.Date
Start-Sleep -Seconds 11
$dbatoolsciValid.Refresh()
$dbatoolsciValid.IsRunning | Should Be $true
# Using $script:instance2 because the SMO $server is not updated after the job is removed
(Get-DbaAgentJob -SqlInstance $script:instance2 -Job "XE Session STOP - dbatoolsci_session_valid").Count | Should -Be 0
}

}
Expand Down

0 comments on commit 50b1d2b

Please sign in to comment.