Skip to content

Commit

Permalink
add list of issues in conventions
Browse files Browse the repository at this point in the history
  • Loading branch information
potatoqualitee committed Oct 17, 2024
1 parent 66e5312 commit 701deb2
Showing 1 changed file with 9 additions and 1 deletion.
10 changes: 9 additions & 1 deletion .aider/prompts/conventions.md
Original file line number Diff line number Diff line change
Expand Up @@ -181,4 +181,12 @@ Describe "Connect-DbaInstance" {
2. Implement necessary adjustments for SQL Server-specific testing scenarios while maintaining the integrity of the tests.
3. Leave in comments like "#$script:instance2 for appveyor" -- it's a debugging thing
4. Do not leave in the knownparameters section because it's taken care of by Should -HaveParameter
5. Start with `param($ModuleName = 'dbatools')` like in the example above.
5. Start with `param($ModuleName = 'dbatools')` like in the example above.

## Issues with previous migration

* -Skip:(whatever) should return true or false, not a string
* -Mandatory:$false is how you do a "not mandatory" parameter
* Scoping is different -- you likely need to use $global:whatever instead of $script:whatever
* Type SwitchParameter does not exist. it's Switch
* SMO objects were shortened from [Microsoft.SqlServer.Management.Smo.Table[]]$InputObject to Table[] in the Paramter check and that broke the tests. Same for Database and BigInteger (which is bigint)

0 comments on commit 701deb2

Please sign in to comment.