New-DbaComputerCertifficate - Only use MonthsValid for self-signed ce…

…rtificates (#9318)
dataplat · Apr 11, 2024 · 95c9644 · 95c9644
1 parent 7043c26
commit 95c9644
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/public/New-DbaComputerCertificate.ps1 b/public/New-DbaComputerCertificate.ps1
@@ -349,11 +349,11 @@ function New-DbaComputerCertificate {
                 Add-Content $certCfg "ProviderType = 12"
                 if ($SelfSigned) {
                     Add-Content $certCfg "RequestType = Cert"
+                    Add-Content $certCfg "NotBefore = $((get-date).ToShortDateString())"
+                    Add-Content $certCfg "NotAfter = $((get-date).AddMonths($MonthsValid).ToShortDateString())"
                 } else {
                     Add-Content $certCfg "RequestType = PKCS10"
                 }
-                Add-Content $certCfg "NotBefore = $((get-date).ToShortDateString())"
-                Add-Content $certCfg "NotAfter = $((get-date).AddMonths($MonthsValid).ToShortDateString())"
                 Add-Content $certCfg "HashAlgorithm = $HashAlgorithm"
                 Add-Content $certCfg "KeyUsage = 0xa0"
                 Add-Content $certCfg "[EnhancedKeyUsageExtension]"