Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connect-DbaInstance - Open connection to get CurrentDatabase #9308

Merged
merged 5 commits into from
Apr 12, 2024
Merged

Connect-DbaInstance - Open connection to get CurrentDatabase #9308

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d5201fe
Open connection to get CurrentDatabase
andreasjordan Mar 31, 2024
07dd775
Merge branch 'development' into ConnectDbaInstance_get_spid
potatoqualitee Apr 11, 2024
3587ebd
Merge branch 'development' into ConnectDbaInstance_get_spid
potatoqualitee Apr 11, 2024
160061b
fix issues with connection pooling
andreasjordan Apr 11, 2024
ffacb22
connect only if needed
andreasjordan Apr 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions public/Connect-DbaInstance.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -595,9 +595,17 @@ function Connect-DbaInstance {
# Currently only if we have a different Database or have to switch to a NonPooledConnection or using a specific StatementTimeout or using ApplicationIntent
# We do not test for SqlCredential as this would change the behavior compared to the legacy code path
$copyContext = $false
if ($Database -and $inputObject.ConnectionContext.CurrentDatabase -ne $Database) {
Write-Message -Level Verbose -Message "Database provided. Does not match ConnectionContext.CurrentDatabase, copying ConnectionContext and setting the CurrentDatabase"
$copyContext = $true
if ($Database) {
Write-Message -Level Debug -Message "Database [$Database] provided."
if (-not $inputObject.ConnectionContext.CurrentDatabase) {
Write-Message -Level Debug -Message "ConnectionContext.CurrentDatabase is empty, so connection will be opened to get the value"
$inputObject.ConnectionContext.Connect()
Write-Message -Level Debug -Message "ConnectionContext.CurrentDatabase is now [$($inputObject.ConnectionContext.CurrentDatabase)]"
}
if ($inputObject.ConnectionContext.CurrentDatabase -ne $Database) {
Write-Message -Level Verbose -Message "Database [$Database] provided. Does not match ConnectionContext.CurrentDatabase [$($inputObject.ConnectionContext.CurrentDatabase)], copying ConnectionContext and setting the CurrentDatabase"
$copyContext = $true
}
}
if ($ApplicationIntent -and $inputObject.ConnectionContext.ApplicationIntent -ne $ApplicationIntent) {
Write-Message -Level Verbose -Message "ApplicationIntent provided. Does not match ConnectionContext.ApplicationIntent, copying ConnectionContext and setting the ApplicationIntent"
Expand Down
Loading