-
-
Notifications
You must be signed in to change notification settings - Fork 817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add-DbaDbRoleMember - Add support for adding roles to roles #9319
Conversation
We have to change Get-DbaDbRoleMember as well. Will work on this in the next days. |
I added them member roles to |
The code looks good. Thanks! Would love to see |
Let's first have @potatoqualitee have a look at this PR. Then we can talk about breaking changes. |
thank you for the alias! @ClaudioESSilva can you pls take a look and approve? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just rewording suggesting...but LGTM
Co-authored-by: Shawn Melton <[email protected]>
oh, good. thanks everyone 😊 |
Type of Change
Add-DbaDbRoleMember
- Unable to Add Role #9302 ).\tests\manual.pester.ps1
)See issue for details.