Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add-DbaDbRoleMember - Add support for adding roles to roles #9319

Merged
merged 5 commits into from
Apr 12, 2024

Conversation

andreasjordan
Copy link
Contributor

Type of Change

  • Bug fix (non-breaking change, fixes Add-DbaDbRoleMember - Unable to Add Role #9302 )
  • New feature (non-breaking change, adds functionality, fixes # )
  • Breaking change (affects multiple commands or functionality, fixes # )
  • Ran manual Pester test and has passed (.\tests\manual.pester.ps1)
  • Adding code coverage to existing functionality
  • Pester test is included
  • If new file reference added for test, has is been added to github.com/dataplat/appveyor-lab ?
  • Unit test is included
  • Documentation
  • Build system

See issue for details.

@andreasjordan
Copy link
Contributor Author

We have to change Get-DbaDbRoleMember as well. Will work on this in the next days.

@andreasjordan andreasjordan marked this pull request as draft April 3, 2024 20:25
@andreasjordan andreasjordan marked this pull request as ready for review April 8, 2024 18:57
@andreasjordan
Copy link
Contributor Author

I added them member roles to Get-DbaDbRoleMember in a way that this is a non-breaking change. But I would prefer changing the output in a way that we don't use "user" or "role" but "member". But that would be a breaking change. Maybe planning that for the next major version?

@mattcargile
Copy link
Contributor

The code looks good. Thanks!

Would love to see DbaServerRoleMember cmdlets get the same treatment on the parameters. Might involve more breaking changes.

@andreasjordan
Copy link
Contributor Author

Let's first have @potatoqualitee have a look at this PR. Then we can talk about breaking changes.

@potatoqualitee
Copy link
Member

thank you for the alias! @ClaudioESSilva can you pls take a look and approve?

Copy link
Member

@wsmelton wsmelton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just rewording suggesting...but LGTM

@andreasjordan andreasjordan requested a review from wsmelton April 11, 2024 15:38
@potatoqualitee
Copy link
Member

oh, good. thanks everyone 😊

@potatoqualitee potatoqualitee merged commit 76998ae into development Apr 12, 2024
12 checks passed
@potatoqualitee potatoqualitee deleted the AddDbaDbRoleMember_support_roles branch April 12, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add-DbaDbRoleMember - Unable to Add Role
4 participants