Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set-DbaLogin, report correct name for -WhatIf #9582

Merged
merged 1 commit into from
Feb 24, 2025

Conversation

niphlod
Copy link
Contributor

@niphlod niphlod commented Feb 10, 2025

Type of Change

  • Bug fix (non-breaking change, fixes Set-DBALogin -whatif inaccurate server information #9580 )
  • New feature (non-breaking change, adds functionality, fixes # )
  • Breaking change (affects multiple commands or functionality, fixes # )
  • Ran manual Pester test and has passed (Invoke-ManualPester)
  • Adding code coverage to existing functionality
  • Pester test is included
  • If new file reference added for test, has is been added to github.com/dataplat/appveyor-lab ?
  • Unit test is included
  • Documentation
  • Build system

Approach

Printing was fixed on first server, indeed. Every login has a "Parent" object that is the server the login is from, so a quick property swap and the print is now okay for all.

Thanks @Sirwill1968 for reporting

@potatoqualitee potatoqualitee merged commit 8abb18d into dataplat:development Feb 24, 2025
3 checks passed
@potatoqualitee
Copy link
Member

Thank you 🙏🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set-DBALogin -whatif inaccurate server information
2 participants