Backup-DbaDbCertificate, new FileBaseName parameter #9597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 22, 2025
|
Thank you 🙏🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Invoke-ManualPester)Purpose
Was not convinced myself but the latest point from @serenefiresiren hit the spot, i.e. "I need my own structure because when restoring it's easier if I maintain my own conventions". Thinking of a disaster event, quick spotting of what cert has what name and ends up named by whatever convention is established is not a big deal and, frankly, it's not a mega-modification that needs certain care.
Approach
Just trust the passed parameter that overrides the default naming, and slap a regression test to make sure the feature stays in.