Gavrenkov/gunicorn gevent runtime #1644
Draft
+319
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gevent_runtime # Conflicts: # custom_model_runner/datarobot_drum/drum/root_predictors/prediction_server.py
yakov-g
reviewed
Aug 29, 2025
custom_model_runner/requirements.txt
Outdated
| @@ -3,6 +3,8 @@ argcomplete | |||
| trafaret>=2.0.0 | |||
| docker>=4.2.2 | |||
| flask | |||
| gevent>=22.10.2 | |||
There was a problem hiding this comment.
We try to avoid pinning versions here, instead we pin them in the environment
yakov-g
reviewed
Aug 29, 2025
| ) | ||
| if server_type == "gunicorn": | ||
| logger.info("Starting gunicorn server") | ||
| try: |
There was a problem hiding this comment.
probably this can be removed as we require gunicorn
There was a problem hiding this comment.
Maybe import can be even moved to the beginning of the file
yakov-g
reviewed
Aug 29, 2025
| "DRUM_GUNICORN_WORKER_CLASS" | ||
| ): | ||
| if ( | ||
| str(RuntimeParameters.has("DRUM_SERVER_TYPE")).lower() == "gunicorn" |
There was a problem hiding this comment.
Maybe define gunicorn, gevent as constants? THey are reused in several places
yakov-g
approved these changes
Aug 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This repository is public. Do not put here any private DataRobot or customer's data: code, datasets, model artifacts, .etc.
Summary
Rationale