[RAPTOR-15086] Add vLLM Dockerfile build tests #1760
Merged
+267
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reza-mahdiani-m
changed the title
reza-mahdiani-m
force-pushed
the
vll_image_test
branch
from
85f6e8b to
21511cc
Compare
- Add 3 tests for Docker build, components, and security validation - CPU-only tests compatible with CI harness (no GPU required) - Tests run in ~4-5 minutes with Docker image caching - Comprehensive README with troubleshooting guide - Non-invasive: no changes to existing code Tests validate: - Docker image builds successfully - Python 3.12, virtualenv, and paths exist - Container runs as non-root user (security)
reza-mahdiani-m
force-pushed
the
vll_image_test
branch
from
21511cc to
f6e4fed
Compare
|
The Needs Review labels were added based on the following file changes. Team @datarobot/core-modeling (#predictive-ai) was assigned because of changes in files:tests/functional/test_vllm/README.md tests/functional/test_vllm/test_dockerfile.py Team @datarobot/genai-systems (#genai-systems) was assigned because of changes in files:tests/functional/test_vllm/README.md tests/functional/test_vllm/test_dockerfile.py If you think that there are some issues with ownership, please discuss with C&A domain at #sdtk slack channel and create PR to update DRCODEOWNERS\CODEOWNERS file. |
Contributor
Author
|
Thanks @mbromanowsky |
|
@reza-mahdiani-m , did you ever get a review from GenAI Systems? I reviewed for Predictive AI, since we are co-owners of the affected files, but this PR was about LLMs, so GenAI are the experts and main stakeholders. I think you should have waited for their approval. |
reza-mahdiani-m
added a commit
that referenced
this pull request
Nov 19, 2025
This reverts commit f19a532.
Contributor
Author
|
My bad., As it is just new tests and documentation, I did not revert them back. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds CPU-based CI tests for vLLM Docker environment build validation.
Changes:
make functional-testsTest Coverage:
✅ Docker image builds without errors
✅ Python 3.12, virtualenv, required paths present
✅ Container runs as non-root (uid 1000)