-
Notifications
You must be signed in to change notification settings - Fork 88
[RAPTOR-15042] hard upgrade of DRUM and other deps in all the envs except agents #1769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The Needs Review labels were added based on the following file changes. Team @datarobot/core-modeling (#predictive-ai) was assigned because of changes in files:public_dropin_environments/python3_keras/env_info.json public_dropin_environments/python3_keras/requirements.txt public_dropin_environments/python3_pytorch/env_info.json public_dropin_environments/python3_pytorch/requirements.txt public_dropin_environments/python3_sklearn/env_info.json public_dropin_environments/python3_sklearn/requirements.txt public_dropin_environments/python3_xgboost/env_info.json public_dropin_environments/python3_xgboost/requirements.txt public_dropin_environments/r_lang/env_info.json public_dropin_environments/r_lang/requirements.txt Team @datarobot/genai-systems (#genai-systems) was assigned because of changes in files:model_templates/python3_xgboost/xgb_reg.pkl public_dropin_environments/java_codegen/env_info.json public_dropin_environments/java_codegen/requirements.txt public_dropin_environments/python311/env_info.json public_dropin_environments/python311/requirements.txt public_dropin_environments/python3_keras/env_info.json public_dropin_environments/python3_keras/requirements.txt public_dropin_environments/python3_onnx/env_info.json public_dropin_environments/python3_onnx/requirements.txt public_dropin_environments/python3_pytorch/env_info.json public_dropin_environments/python3_pytorch/requirements.txt public_dropin_environments/python3_sklearn/env_info.json public_dropin_environments/python3_sklearn/requirements.txt public_dropin_environments/python3_xgboost/env_info.json public_dropin_environments/python3_xgboost/requirements.txt public_dropin_environments/r_lang/env_info.json public_dropin_environments/r_lang/requirements.txt public_dropin_gpu_environments/vllm/env_info.json public_dropin_gpu_environments/vllm/requirements.txt tests/fixtures/drop_in_model_artifacts/xgb_bin.pkl tests/fixtures/drop_in_model_artifacts/xgb_multi.pkl tests/fixtures/drop_in_model_artifacts/xgb_reg.pkl If you think that there are some issues with ownership, please discuss with C&A domain at #sdtk slack channel and create PR to update DRCODEOWNERS\CODEOWNERS file. |
|
Label Needs Review: GenAI Systems was removed because @s-gavrenkov is part of GenAI Systems domain. |
18d8d89 to
88de0e5
Compare
| # Setting OMP_NUM_THREADS=1 forces XGBoost to use only one thread per process. | ||
| # If we need to use wekzeug max_workers > 1 in DRUM, we must set OMP_NUM_THREADS=1 to avoid potential hangs. | ||
| # Maybe the same would apply to gunicorn, when we test. | ||
| # ENV OMP_NUM_THREADS=1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@s-gavrenkov
@nullspoon
@klichukb
Just heads up that we may need this env var configured if we ever use werkzeug max_workers>1
For now I set it only in the related tests.
mbromanowsky
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for Predictive AI
88de0e5 to
83e077e
Compare
This repository is public. Do not put here any private DataRobot or customer's data: code, datasets, model artifacts, .etc.
Summary
Bump drum in envs to 1.17.8
Rationale
Note
Upgrades dependencies and env versions across drop-in environments (including DRUM 1.17.8) and updates tests to set OMP_NUM_THREADS for XGBoost when using multiple workers.
datarobot-drumto1.17.8,datarobotto3.9.1, OpenTelemetry stack to1.38.0/0.59b0,pillowto12.0.0, AWS/Google SDKs, and other libs; updateenv_info.jsonenvironmentVersionIdandtags.aiohttp,openai,jiter) while keeping labelv0.10.0and updating env version metadata.torch 2.9.1,triton 3.5.1, and newer CUDA/NCCL/NVSHMEM libs.onnxruntimeto1.23.2.xgboostto3.1.2; add Dockerfile comments reOMP_NUM_THREADSfor multi-worker stability.max_workers > 1, setOMP_NUM_THREADS=1and unset after tests.Written by Cursor Bugbot for commit 83e077e. This will update automatically on new commits. Configure here.