Skip to content

Replace test for Apple Mx processors#422

Merged
StuartWheater merged 1 commit intodatashield:v6.3.4-devfrom
villegar:v6.3.4-dev
Aug 23, 2025
Merged

Replace test for Apple Mx processors#422
StuartWheater merged 1 commit intodatashield:v6.3.4-devfrom
villegar:v6.3.4-dev

Conversation

@villegar
Copy link
Copy Markdown
Contributor

@villegar villegar commented Aug 22, 2025

Replace test for Apple Mx processors without assumptions of tolerance, this test is these tests are based on observed behaviour for the stats::cor and stats::cor.test functions, where the approximation for the correlation for some vectors is nearly 1, resulting in 1 - cor(x, y) > 0, when the expected value should be 0. For example, when x = y = c(0.0, 3.0, 7.0)

…, this test is based on observed behaviour for the stats::cor and stats::cor.test functions, where the approximation for the correlation for some vectors is nearly 1, resulting in 1 - cor(x, y) > 0, when the expected value should be 0. For example, when x = y = c(0.0, 3.0, 7.0)
@villegar villegar requested a review from StuartWheater August 22, 2025 15:13
@StuartWheater
Copy link
Copy Markdown
Member

Thanks, will create RC4 tomorrow (probably), and will include "Replace test for Apple Mx process ..." text in the notes to the CRAN.

@codecov-commenter
Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 29.42%. Comparing base (2c209f0) to head (b8e80af).
⚠️ Report is 17 commits behind head on v6.3.4-dev.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           v6.3.4-dev     #422   +/-   ##
===========================================
  Coverage       29.42%   29.42%           
===========================================
  Files             138      138           
  Lines            5729     5729           
===========================================
  Hits             1686     1686           
  Misses           4043     4043           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@StuartWheater StuartWheater merged commit a57c91a into datashield:v6.3.4-dev Aug 23, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants