Skip to content

fix: return family name in glmDS2 result#466

Open
ymarcon wants to merge 1 commit intodatashield:masterfrom
epigeny:master
Open

fix: return family name in glmDS2 result#466
ymarcon wants to merge 1 commit intodatashield:masterfrom
epigeny:master

Conversation

@ymarcon
Copy link
Copy Markdown
Member

@ymarcon ymarcon commented Mar 29, 2026

Fix for #465, glmDS2 only.

The returned value in JSON is now

{
  "server1": {
    "family": "binomial",
    "info.matrix": [
      [
        433,
        216.5,
        11854.745,
        680.874629249998
      ],
      [
        216.5,
        216.5,
        5813.9525,
        351.703075
      ],
      [
        11854.745,
        5813.9525,
        334837.6683,
        18532.8212879925
      ],
      [
        680.874629249998,
        351.703075,
        18532.8212879925,
        1144.17968050697
      ]
    ],
    "score.vect": [
      [
        -842
      ],
      [
        -424
      ],
      [
        -22985.76
      ],
      [
        -1327.9215585
      ]
    ],
    "numsubs": 1732,
    "dev": 2401.06183345965,
    "Nvalid": 1732,
    "Nmissing": 431,
    "Ntotal": 2163,
    "disclosure.risk": 0,
    "errorMessage2": "No errors"
  }
}

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 29, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 29.90%. Comparing base (05c8de2) to head (feddf41).
⚠️ Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
R/glmDS2.R 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #466      +/-   ##
==========================================
- Coverage   30.67%   29.90%   -0.77%     
==========================================
  Files         139      139              
  Lines        5320     5761     +441     
==========================================
+ Hits         1632     1723      +91     
- Misses       3688     4038     +350     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant