Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNDB-12346: Fix reporting enqueue time for stage tasks (#1490) #1493

Open
wants to merge 1 commit into
base: cndb-main-release-20241217
Choose a base branch
from

Conversation

jakubzytka
Copy link

@jakubzytka jakubzytka commented Jan 9, 2025

Enqueue start time will now be correctly measured for every API for task
execution

What is the issue

Enqueue start times are measured at a wrong moment for some APIs.

What does this PR fix and why was it fixed

We now measure the enqueue start time as a time of entry to each task
execution API.
It was fixed so that we see the correct enqueue times in metrics

Checklist before you submit for review

  • Make sure there is a PR in the CNDB project updating the Converged Cassandra version
  • Use NoSpamLogger for log lines that may appear frequently in the logs
  • Verify test results on Butler
  • Test coverage for new/modified code is > 80%
  • Proper code formatting
  • Proper title for each commit staring with the project-issue number, like CNDB-1234
  • Each commit has a meaningful description
  • Each commit is not very long and contains related changes
  • Renames, moves and reformatting are in distinct commits

Enqueue start time will now be correctly measured for every API for task
execution

### What is the issue
Enqueue start times are measured at a wrong moment for some APIs.

### What does this PR fix and why was it fixed
We now measure the enqueue start time as a time of entry to each task
execution API.
It was fixed so that we see the correct enqueue times in metrics
@cassci-bot
Copy link

❌ Build ds-cassandra-pr-gate/PR-1493 rejected by Butler


8 new test failure(s) in 1 builds
See build details here


Found 8 new test failures

Test Explanation Branch history Upstream history
t.TestCqlshUnicode.test_unicode_identifier regression 🔴
t.TestCqlshUnicode.test_unicode_value_round_trip regression 🔴
...adRepairGuarantees.test_atomic_writes[blocking] regression 🔴
...ToolEnableDisableBinaryTest.testMaybeChangeDocs regression 🔴
...ist,wide=false,scenario=MEMTABLE_QUERY] regression 🔴
...t.testKDTreePostingsQueryMetricsWithSingleIndex regression 🔴
...m.TrieMemtableMetricsTest.testContentionMetrics regression 🔴
o.a.c.u.b.BinLogTest.testTruncationReleasesLogS... regression 🔴

No known test failures found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants