Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNDB-12425: A few reproduction tests and a preliminary patch, WIP #1529

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ekaterinadimitrova2
Copy link

What is the issue

...
Queries with ALLOW FILTERING are rejected while we have an index that can be used in the future for the same query, still building

What does this PR fix and why was it fixed

...

Checklist before you submit for review

  • Make sure there is a PR in the CNDB project updating the Converged Cassandra version
  • Use NoSpamLogger for log lines that may appear frequently in the logs
  • Verify test results on Butler
  • Test coverage for new/modified code is > 80%
  • Proper code formatting
  • Proper title for each commit staring with the project-issue number, like CNDB-1234
  • Each commit has a meaningful description
  • Each commit is not very long and contains related changes
  • Renames, moves and reformatting are in distinct commits

@ekaterinadimitrova2 ekaterinadimitrova2 marked this pull request as draft January 23, 2025 03:20
@ekaterinadimitrova2 ekaterinadimitrova2 self-assigned this Jan 23, 2025
@@ -1053,11 +1056,30 @@ public ReadCommand deserialize(DataInputPlus in, int version) throws IOException
if (hasIndex)
{
IndexMetadata index = deserializeIndexMetadata(in, version, metadata);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code in this method is ugly draft. I will clean and optimize it.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
74.7% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@cassci-bot
Copy link

❌ Build ds-cassandra-pr-gate/PR-1529 rejected by Butler


390 new test failure(s) in 1 builds
See build details here


Found 390 new test failures

Showing only first 15 new test failures

Test Explanation Branch history Upstream history
o.a.c.d.CounterMutationTest.testAddingWithoutLocks regression 🔴 🔵🔵🔵🔵🔵🔵🔵
...dCommandTest.skipRowCacheIfTrackingRepairedData regression 🔴 🔵🔵🔵🔵🔵🔵🔵
o.a.c.d.ReadMessageTest.testMakeReadMessage regression 🔴 🔵🔵🔵🔵🔵🔵🔵
o.a.c.d.RecoveryManagerTest.testRecoverPIT[2] regression 🔴 🔵🔵🔵🔵🔵🔵🔵
...heTest.testSSTablesPerReadHistogramWhenRowCache regression 🔴 🔵🔵🔵🔵🔵🔵🔵
...d.RowIterationTest.testRowIterationDeletionTime regression 🔴 🔵🔵🔵🔵🔵🔵🔵
o.a.c.d.ScrubTest.testFailScrubCompositeIndex regression 🔴 🔵🔵🔵🔵🔵🔵🔵
o.a.c.d.KeyCollisionTest.testGetSliceWithCollision regression 🔴 🔵🔵🔵🔵🔵🔵🔵
o.a.c.h.HintTest.testChangedTopologyNotHintable regression 🔴 🔵🔵🔵🔵🔵🔵🔵
o.a.c.i.s.SASIIndexTest.testCrossSSTableQueries regression 🔴 🔵🔵🔵🔵🔵🔵🔵
o.a.c.i.s.SASIIndexTest.testEmptyTokenizedResults regression 🔴 🔵🔵🔵🔵🔵🔵🔵
o.a.c.i.s.SASIIndexTest.testInvalidate regression 🔴 🔵🔵🔵🔵🔵🔵🔵
o.a.c.s.QueryPagerTest.reversedSliceQueryTest regression 🔴 🔵🔵🔵🔵🔵🔵🔵
o.a.c.s.r.DataResolverTest.testResolveWithBothE... regression 🔴 🔵🔵🔵🔵🔵🔵🔵
o.a.c.s.r.DataResolverTest.testResolveWithOneEmpty regression 🔴 🔵🔵🔵🔵🔵🔵🔵

Found 4 known test failures

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants